Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add packaging to dependencies #12753

Merged
merged 3 commits into from
Aug 16, 2022
Merged

Add packaging to dependencies #12753

merged 3 commits into from
Aug 16, 2022

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Aug 15, 2022

Motivation

#12560

@ofek ofek requested review from a team as code owners August 15, 2022 19:30
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

yzhan289
yzhan289 previously approved these changes Aug 15, 2022
View reviewed changes
@yzhan289
Copy link
Contributor

Validations seem to be failing for license?

@codecov
Copy link

codecov bot commented Aug 15, 2022 •
edited
Loading

Codecov Report

Merging #12753 (b396db5) into master (bc5cb96) will increase coverage by 0.01%.
The diff coverage is n/a.

Flag Coverage Δ
datadog_checks_downloader 80.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

djmitche
djmitche previously approved these changes Aug 15, 2022
View reviewed changes
fanny-jiang
fanny-jiang previously approved these changes Aug 15, 2022
View reviewed changes
@fanny-jiang
Copy link
Contributor

Looks like validate-agent-build is now failing

ERROR: Could not find a version that satisfies the requirement packaging==21.3 (from -r /omnibus/src/datadog-agent-integrations-py2/integrations-core/agent_requirements-py2.in (line 52)) (from versions: 14.0, 14.1, 14.2, 14.3, 14.4, 14.5, 15.0, 15.1, 15.2, 15.3, 16.0, 16.1, 16.2, 16.3, 16.4, 16.5, 16.6, 16.7, 16.8, 17.0, 17.1, 18.0, 19.0, 19.1, 19.2, 20.0, 20.1, 20.2, 20.3, 20.4, 20.5, 20.6, 20.7, 20.8, 20.9)

@ofek ofek dismissed stale reviews from fanny-jiang and djmitche via b396db5 August 16, 2022 02:55
@ofek ofek requested a review from a team as a code owner August 16, 2022 02:55
@ofek ofek merged commit 16783a5 into master Aug 16, 2022
@ofek ofek deleted the ofek/dep branch August 16, 2022 14:18
github-actions bot pushed a commit that referenced this pull request Aug 16, 2022
@ofek
Add packaging to dependencies (#12753)
a48d28c 
* Add `packaging` to dependencies

* Update LICENSE-3rdparty.csv

* fix 16783a5
@yzhan289 yzhan289 mentioned this pull request Aug 16, 2022
Merged
4 tasks
steveny91 pushed a commit that referenced this pull request Aug 18, 2022
@ofek @steveny91
Add packaging to dependencies (#12753)
4a0ceae 
* Add `packaging` to dependencies

* Update LICENSE-3rdparty.csv

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorentClarret FlorentClarret FlorentClarret approved these changes

@djmitche djmitche djmitche left review comments

@fanny-jiang fanny-jiang fanny-jiang left review comments

@yzhan289 yzhan289 yzhan289 left review comments

Assignees
No one assigned
Labels
dependencies integration/datadog_checks_base integration/datadog_checks_downloader
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ofek @yzhan289 @fanny-jiang @djmitche @FlorentClarret