Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document feature in journald user-level filtering #13713

Merged
merged 4 commits into from
Jan 19, 2023
Merged

Document feature in journald user-level filtering #13713

merged 4 commits into from
Jan 19, 2023

Conversation

ian28223
Copy link
Contributor

What does this PR do?

Document feature in introduced in #11398

Motivation

  • AGENT-7627
  • FRAGENT-1752

Additional Notes

Same as #13701 13701

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@ian28223 ian28223 requested review from a team as code owners January 17, 2023 02:12
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

1 similar comment
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

urseberry
urseberry reviewed Jan 17, 2023
View reviewed changes
journald/README.md Outdated Show resolved Hide resolved
journald/assets/configuration/spec.yaml Outdated Show resolved Hide resolved
journald/assets/configuration/spec.yaml Outdated Show resolved Hide resolved
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@ian28223 ian28223 force-pushed the ian.bucad/journald_user_filter branch 2 times, most recently from 6148c44 to 68af58e Compare January 18, 2023 04:17
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

1 similar comment
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@ian28223 ian28223 force-pushed the ian.bucad/journald_user_filter branch from 68af58e to f76571a Compare January 18, 2023 05:13
@steveny91 steveny91 merged commit 61abb5e into master Jan 19, 2023
@steveny91 steveny91 deleted the ian.bucad/journald_user_filter branch January 19, 2023 21:24
github-actions bot pushed a commit that referenced this pull request Jan 19, 2023
@steveny91 @kayayarai
Document feature in journald user-level filtering (#13713)
e94e4b0 
* Document feature in #11398

* Apply suggestions from code review

Co-authored-by: Kari Halsted <[email protected]>

* Update example config

* Apply suggestions from code review

Co-authored-by: Ursula Chen <[email protected]>

Co-authored-by: Kari Halsted <[email protected]>
Co-authored-by: Ursula Chen <[email protected]> 61abb5e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveny91 steveny91 steveny91 approved these changes

@urseberry urseberry urseberry approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog documentation integration/journald
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ian28223 @steveny91 @urseberry