Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extend and refactor tests #13737

Merged
merged 2 commits into from
Jan 19, 2023
Merged

extend and refactor tests #13737

merged 2 commits into from
Jan 19, 2023

Conversation

iliakur
Copy link
Contributor

@iliakur iliakur commented Jan 19, 2023

What does this PR do?

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@iliakur iliakur requested a review from a team as a code owner January 19, 2023 15:58
This was referenced Jan 19, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@iliakur Graphite App
Copy link
Contributor Author

iliakur commented Jan 19, 2023 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@iliakur iliakur force-pushed the 01-18-validate_check_configuration_values branch from 0c55394 to a48d9e4 Compare January 19, 2023 17:02
@iliakur iliakur force-pushed the 01-19-extend_and_refactor_tests branch from 256eb8c to f4325e9 Compare January 19, 2023 17:02
@iliakur iliakur force-pushed the 01-18-validate_check_configuration_values branch from a48d9e4 to 511aedd Compare January 19, 2023 17:16
@iliakur iliakur force-pushed the 01-19-extend_and_refactor_tests branch from f4325e9 to b748a01 Compare January 19, 2023 17:16
@iliakur iliakur force-pushed the 01-18-validate_check_configuration_values branch from 511aedd to 482a456 Compare January 19, 2023 17:22
@iliakur iliakur requested a review from a team as a code owner January 19, 2023 17:22
@iliakur iliakur force-pushed the 01-19-extend_and_refactor_tests branch from b748a01 to 4733b4e Compare January 19, 2023 17:22
@iliakur iliakur force-pushed the 01-18-validate_check_configuration_values branch from 482a456 to 0d4340b Compare January 19, 2023 17:23
@iliakur iliakur force-pushed the 01-19-extend_and_refactor_tests branch from 4733b4e to bc93102 Compare January 19, 2023 17:24
@iliakur iliakur force-pushed the 01-18-validate_check_configuration_values branch from 0d4340b to 92a5a7e Compare January 19, 2023 17:28
@iliakur iliakur force-pushed the 01-19-extend_and_refactor_tests branch from bc93102 to 63e4cff Compare January 19, 2023 17:28
@iliakur iliakur force-pushed the 01-18-validate_check_configuration_values branch from 92a5a7e to bb41256 Compare January 19, 2023 17:30
@iliakur iliakur force-pushed the 01-19-extend_and_refactor_tests branch from 63e4cff to c31e757 Compare January 19, 2023 17:31
@iliakur iliakur force-pushed the 01-18-validate_check_configuration_values branch from bb41256 to e89e7fe Compare January 19, 2023 17:32
@iliakur iliakur force-pushed the 01-19-extend_and_refactor_tests branch from c31e757 to 32f428b Compare January 19, 2023 17:32
Base automatically changed from 01-18-validate_check_configuration_values to ik/AI-2736/rabbitmq-openmetrics January 19, 2023 17:33
@iliakur iliakur force-pushed the 01-19-extend_and_refactor_tests branch from 32f428b to 91e91f9 Compare January 19, 2023 17:33
@iliakur iliakur merged commit 480a942 into ik/AI-2736/rabbitmq-openmetrics Jan 19, 2023
@iliakur iliakur deleted the 01-19-extend_and_refactor_tests branch January 19, 2023 17:34
iliakur added a commit that referenced this pull request Jan 19, 2023
@iliakur
extend and refactor tests (#13737)
15a15c9 
* extend and refactor tests

* add comment explaining assertion
iliakur added a commit that referenced this pull request Jan 20, 2023
@iliakur
extend and refactor tests (#13737)
8b7456a 
* extend and refactor tests

* add comment explaining assertion
iliakur added a commit that referenced this pull request Jan 20, 2023
@iliakur
extend and refactor tests (#13737)
f3a265b 
* extend and refactor tests

* add comment explaining assertion
fanny-jiang added a commit that referenced this pull request Jan 20, 2023
@iliakur @alai97
@fanny-jiang @buraizu @estherk15
Support RabbitMQ Prometheus Metrics (#13662)
7f9a405 
* Setting the stage (#13437)

### What does this PR do?
<!-- A brief description of the change being made with this pull request. -->

The Openmetrics-related changes are minimal: just a basic class and a test that mostly makes sure that this class can be imported and run.

The rest is scaffolding: I needed new versions of rmq to test out my changes, the old tests needed adjusting to pass -> one config field had to be made optional to make sure my tests run -> etc...


### Motivation
<!-- What inspired you to submit this pull request? -->

### Additional Notes
<!-- Anything else we should know when reviewing? -->

### Review checklist (to be filled by reviewers)

- [ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
- [ ] PR title must be written as a CHANGELOG entry [(see why)](https://github.com/DataDog/integrations-core/blob/master/CONTRIBUTING.md#pull-request-title)
- [ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
- [ ] PR must have `changelog/` and `integration/` labels attached
- [ ] If the PR doesn't need to be tested during QA, please add a `qa/skip-qa` label.

* Only select aggregated endpoint (#13673)

* only aggregated endpoint

* fix erlang.vm.allocators assertion

* copy suggestions

Co-authored-by: Austin Lai <[email protected]>

* Update rabbitmq/assets/configuration/spec.yaml

Co-authored-by: Austin Lai <[email protected]>

* Update models and example config to reflect current spec

* Don't test rabbitmq 3.8 (openmetrics) with python2

* fix PY2 failure

* consistent python env names; better setup to skip openmetrics tests

* Add openmetrics to E2E environment (#13695)

* add openmetrics e2e

* re-add newline to compose file

* revert hatch.toml changes

Co-authored-by: Austin Lai <[email protected]>
Co-authored-by: Fanny Jiang <[email protected]>

* add more metrics to aggregated endpoint (#13684)

* add more metrics to aggregated endpoint

* separate out summary metrics

* Refactor aggregated endpoint test (#13730)

* refactor aggregated endpoints test

* add missing metrics

* fix dd metric names

Co-authored-by: Fanny Jiang <[email protected]>

* support for specifying just detailed endpoint (#13691)

* support for specifying just detailed endpoint

* Update rabbitmq/datadog_checks/rabbitmq/data/conf.yaml.example

Co-authored-by: Bryce Eadie <[email protected]>

* Update rabbitmq/datadog_checks/rabbitmq/data/conf.yaml.example

Co-authored-by: Bryce Eadie <[email protected]>

* sync config

* apply and sync all the suggestions

Co-authored-by: Bryce Eadie <[email protected]>

* support for specifying just per-object endpoint (#13692)

* support for specifying just per-object endpoint

* Style fix: remove f-string without interpolation

* specify both detailed and aggregated endpoints in one instance (#13727)

* validate check configuration values (#13728)

* validate check configuration values

* several fixes:

- remove unnecessary validation logic
- fix url in one of the tests,
- fix style
- aggregated endpoint is enabled by default

* extend and refactor tests (#13737)

* extend and refactor tests

* add comment explaining assertion

* document implementation decisions (#13729)

* fix license headers

* Add openmetrics E2E test (#13744)

* enable openmetrics e2e test

* assert metrics

* small docs fixes (#13746)

* add license header to test file

* Define multiple instances in config spec (#13742)

* wip

* resync config

* document example detailed query endpoint

* fix e2e test

* remove example code from validators

* resync config spec

* add missing fields to metadata.csv, fix metric name (#13745)

* add missing fields to metadata.csv, fix metric name

* add special detailed metrics, fix validation errors

* Apply suggestions from code review

Co-authored-by: Fanny Jiang <[email protected]>

* remove last "total" suffixes

* add missing unit names

Co-authored-by: Fanny Jiang <[email protected]>

* readme draft 1

* readme, migration guide

* split integration and e2e tests

* Apply suggestions from code review

Co-authored-by: Fanny Jiang <[email protected]>

* fix license header

* move section

* remove "we" pronoun

* Update rabbitmq/README.md

Co-authored-by: Esther Kim <[email protected]>

* add migration guide section

* fix e2e test

Co-authored-by: Austin Lai <[email protected]>
Co-authored-by: Fanny Jiang <[email protected]>
Co-authored-by: Bryce Eadie <[email protected]>
Co-authored-by: Esther Kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanny-jiang fanny-jiang fanny-jiang approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog integration/rabbitmq
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iliakur @fanny-jiang