Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation for include_aggregated_endpoint #13793

Merged
merged 4 commits into from
Jan 24, 2023
Merged

Conversation

yzhan289
Copy link
Contributor

@yzhan289 yzhan289 commented Jan 24, 2023

What does this PR do?

This PR adds validation for include_aggregated_endpoint requiring it to be true when unaggregated_endpoint is unspecified. Otherwise, the check will run and collect nothing:

andrew.zhang@COMP-C02F513WML87 integrations-core % ddev env check rabbitmq          
=========
Collector
=========

  Running Checks
  ==============
    
    rabbitmq (3.3.0)
    ----------------
      Instance ID: rabbitmq:1f8a86b67a8bf2a9 [OK]
      Configuration Source: file:/etc/datadog-agent/conf.d/rabbitmq.d/rabbitmq.yaml
      Total Runs: 1
      Metric Samples: Last Run: 0, Total: 0
      Events: Last Run: 0, Total: 0
      Service Checks: Last Run: 0, Total: 0
      Average Execution Time : 31ms
      Last Execution Date : 2023-01-24 21:12:23 UTC (1674594743000)
      Last Successful Execution Date : 2023-01-24 21:12:23 UTC (1674594743000)
      

Check has run only once, if some metrics are missing you can try again with --check-rate to see any other metric if available.

Motivation

QA for #13662

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@yzhan289 yzhan289 requested review from a team as code owners January 24, 2023 21:40
@ghost ghost added the documentation label Jan 24, 2023
@yzhan289 yzhan289 mentioned this pull request Jan 24, 2023
12 tasks
@yzhan289 yzhan289 changed the title Add validation for include_aggregated_endpoint Add validation for include_aggregated_endpoint Jan 24, 2023
fanny-jiang
fanny-jiang previously approved these changes Jan 24, 2023
steveny91
steveny91 previously approved these changes Jan 24, 2023
@yzhan289 yzhan289 dismissed stale reviews from steveny91 and fanny-jiang via 7acf113 January 24, 2023 21:50
fanny-jiang
fanny-jiang previously approved these changes Jan 24, 2023
@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Merging #13793 (2be264f) into master (c329441) will not change coverage.
The diff coverage is n/a.

Flag Coverage Δ
rabbitmq 95.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@yzhan289 yzhan289 merged commit ad8b9d9 into master Jan 24, 2023
@yzhan289 yzhan289 deleted the az/rabbitmq-qa branch January 24, 2023 22:27
steveny91 pushed a commit that referenced this pull request Jan 25, 2023
* Add validation for include_aggregated_endpoint

* Use stronger language

* Use  rather than  for validation error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants