Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand migration docs #14549

Merged
merged 8 commits into from
May 22, 2023
Merged

Expand migration docs #14549

merged 8 commits into from
May 22, 2023

Conversation

iliakur
Copy link
Contributor

@iliakur iliakur commented May 10, 2023 •
edited
Loading

What does this PR do?

Motivation

Part of addressing https://datadoghq.atlassian.net/browse/AGENT-9611, where a customer had suggestions how to improve our documentation.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@iliakur iliakur requested review from a team as code owners May 10, 2023 03:46
@iliakur Graphite App
Copy link
Contributor Author

iliakur commented May 10, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@iliakur iliakur mentioned this pull request May 10, 2023
Merged
5 tasks
@github-actions
Copy link

github-actions bot commented May 10, 2023 •
edited
Loading

Test Results

  36 files    36 suites   9m 46s ⏱️
  39 tests   39 ✔️     0 💤 0 ❌
500 runs  370 ✔️ 130 💤 0 ❌

Results for commit fe8e0c6.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented May 10, 2023 •
edited
Loading

Codecov Report

Merging #14549 (fe8e0c6) into master (8ef6a16) will increase coverage by 1.25%.
The diff coverage is n/a.

Flag Coverage Δ
rabbitmq 95.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

buraizu
buraizu requested changes May 10, 2023
View reviewed changes
Copy link
Contributor

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, just requested a few minor updates per our style guide.

rabbitmq/README.md Outdated Show resolved Hide resolved
rabbitmq/README.md Outdated Show resolved Hide resolved
rabbitmq/README.md Outdated Show resolved Hide resolved
rabbitmq/README.md Outdated Show resolved Hide resolved
rabbitmq/README.md Outdated Show resolved Hide resolved
rabbitmq/README.md Outdated Show resolved Hide resolved
rabbitmq/assets/configuration/spec.yaml Outdated Show resolved Hide resolved
rabbitmq/datadog_checks/rabbitmq/data/conf.yaml.example Outdated Show resolved Hide resolved
@iliakur
Copy link
Contributor Author

iliakur commented May 12, 2023

Thanks @buraizu !

Looks like I gotta review the style guide 🙈

FlorentClarret
FlorentClarret previously approved these changes May 12, 2023
View reviewed changes
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

buraizu
buraizu previously approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for applying those changes, and apologies -- I realize that my suggestions removed an important detail in a couple of places, which I've added back in with this review. Otherwise LGTM and approved.

rabbitmq/datadog_checks/rabbitmq/data/conf.yaml.example Outdated Show resolved Hide resolved
rabbitmq/assets/configuration/spec.yaml Outdated Show resolved Hide resolved
@FlorentClarret FlorentClarret dismissed stale reviews from buraizu and themself via e0179b7 May 15, 2023 07:48
FlorentClarret
FlorentClarret previously approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@FlorentClarret FlorentClarret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Also applied @buraizu fixes

@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@iliakur iliakur force-pushed the ik/expand-migration-docs branch from 7cb2b9e to 5a9cca2 Compare May 19, 2023 06:58
@iliakur iliakur merged commit 4b8d7cb into master May 22, 2023
@iliakur iliakur deleted the ik/expand-migration-docs branch May 22, 2023 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorentClarret FlorentClarret FlorentClarret approved these changes

@buraizu buraizu buraizu left review comments

Assignees
No one assigned
Labels
documentation integration/rabbitmq
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iliakur @FlorentClarret @buraizu