Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the confluent-kafka version #14665

Merged
merged 3 commits into from
Jul 3, 2023

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Jun 1, 2023

What does this PR do?

Bump the confluent-kafka version. Also update the CI to be able to run the tests using this version.

Motivation

We wanted to bump it in this PR be we ran into some issues so we decided to leave this for later.

Additional Notes

Tested with the agent image generated by omnibus:

❯ ddev env start -a 486234852809.dkr.ecr.us-east-1.amazonaws.com/ci/datadog-agent/agent:v16364585-4a91d5b1-7-arm64 kafka_consumer py3.8-3.3-kerberos
Setting up environment `py3.8-3.3-kerberos`... success!
Updating `486234852809.dkr.ecr.us-east-1.amazonaws.com/ci/datadog-agent/agent:v16364585-4a91d5b1-7-arm64`... success!
Detecting the major version... Agent 7 detected
Writing configuration for `py3.8-3.3-kerberos`... success!
Starting the Agent... success!

To edit config file, do: ddev env edit kafka_consumer py3.8-3.3-kerberos
Config file (copied to your clipboard): /Users/florent.clarret/Library/Application Support/dd-checks-dev/envs/kafka_consumer/py3.8-3.3-kerberos/config/kafka_consumer.yaml
To reload the config file, do: ddev env reload kafka_consumer py3.8-3.3-kerberos
To run this check, do: ddev env check kafka_consumer py3.8-3.3-kerberos
To stop this check, do: ddev env stop kafka_consumer py3.8-3.3-kerberos

❯ ddev test --e2e kafka_consumer:py3.8-3.3-kerberos
Running only end-to-end tests for `kafka_consumer`os                                                                                                                          ─╯
--------------------------------------------------
────────────────────────────────────────────────────────────────────────────── py3.8-3.3-kerberos ───────────────────────────────────────────────────────────────────────────────
Finished checking dependencies
cmd [1] | pytest -v --benchmark-skip tests
============================================================================== test session starts ==============================================================================
platform darwin -- Python 3.8.14, pytest-7.3.1, pluggy-1.0.0 -- /Users/florent.clarret/Library/Application Support/hatch/env/virtual/datadog-kafka-consumer/KmLHgHe8/py3.8-3.3-kerberos/bin/python
cachedir: .pytest_cache
benchmark: 4.0.0 (defaults: timer=time.perf_counter disable_gc=False min_rounds=5 min_time=0.000005 max_time=1.0 calibration_precision=10 warmup=False warmup_iterations=100000)
rootdir: /Users/florent.clarret/go/src/github.com/DataDog/integrations-core/kafka_consumer
plugins: memray-1.4.0, datadog-checks-dev-19.3.1, asyncio-0.21.0, ddtrace-0.53.2, flaky-3.7.0, mock-3.10.0, cov-4.1.0, benchmark-4.0.0
asyncio: mode=strict
collected 46 items / 45 deselected / 1 selected                                                                                                                                 

tests/test_e2e.py::test_e2e PASSED                                                                                                                                        [100%]

======================================================================= 1 passed, 45 deselected in 7.56s ========================================================================

Passed!

Needs DataDog/datadog-agent#17266 to be merged first as the dependency is built in omnibus.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@FlorentClarret FlorentClarret requested review from a team as code owners June 1, 2023 06:14
Copy link
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@github-actions
Copy link

github-actions bot commented Jun 1, 2023

Test Results

    8 files      8 suites   6m 28s ⏱️
  46 tests   45 ✔️ 0 💤 1
233 runs  227 ✔️ 5 💤 1

For more details on these failures, see this check.

Results for commit 783447a.

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #14665 (783447a) into master (af1a926) will not change coverage.
The diff coverage is n/a.

❗ Current head 783447a differs from pull request most recent head 3b96825. Consider uploading reports for the commit 3b96825 to get more accurate results

Flag Coverage Δ
kafka_consumer 93.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@yzhan289
Copy link
Contributor

yzhan289 commented Jun 7, 2023

Can we rerun the tests again after DataDog/datadog-agent#17266 is merged to be safe?

@FlorentClarret
Copy link
Member Author

Can we rerun the tests again after DataDog/datadog-agent#17266 is merged to be safe?

That's the plan 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants