Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SNMP] Fix metric length checking #1509

Merged
merged 1 commit into from
May 7, 2018
Merged

Conversation

nmuesch
Copy link
Collaborator

@nmuesch nmuesch commented May 5, 2018

What does this PR do?

Check if the metrics field exists, not its length.

Motivation

If there is nothing there, its actually None so checking its length just throws an exception.

Testing Guidelines

An overview on testing
is available in our contribution guidelines.

Versioning

Resolves issue in unreleased check.

  • Bumped the check version in manifest.json
  • Bumped the check version in datadog_checks/{integration}/__init__.py
  • Updated CHANGELOG.md. Please use Unreleased as the date in the title
    for the new section.
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

Additional Notes

Anything else we should know when reviewing?

@nmuesch nmuesch changed the title Fix metric length checking [SNMP] Fix metric length checking May 5, 2018
@nmuesch nmuesch added this to the 6.2 milestone May 5, 2018
@nmuesch nmuesch merged commit 91cc47f into master May 7, 2018
@masci masci deleted the nick/fix_snmp_exceptions branch May 7, 2018 12:10
masci pushed a commit that referenced this pull request May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants