Set requests stream option to false when scraping Prometheus endpoints #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofek
changed the title
masci
changed the title
masci
approved these changes
Jun 5, 2018
| @@ -474,7 +474,7 @@ def poll(self, endpoint, pFormat=PrometheusFormat.PROTOBUF, headers=None): | |||
| disable_warnings(InsecureRequestWarning) | |||
| verify = False | |||
| try: | |||
| response = requests.get(endpoint, headers=headers, stream=True, timeout=10, cert=cert, verify=verify) | |||
| response = requests.get(endpoint, headers=headers, stream=False, timeout=10, cert=cert, verify=verify) | |||
There was a problem hiding this comment.
nit: the param already defaults to False so you can just remove stream altogether.
masci
deleted the
antoine/prometheus-check-set-request-stream-option-to-false
branch
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Change the stream parameter to the request to False, as we don't stream it.
Motivation
We can avoid here to use this option, as we only store the fetched value, and don't stream it.
Review checklist
no-changeloglabel attached