Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the test that assert external tags #16091

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Update the test that assert external tags #16091

merged 1 commit into from
Oct 27, 2023

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Oct 26, 2023 •
edited
Loading

What does this PR do?

Update the test that assert external tags

Motivation

Use #16089

Additional Notes

Relates to https://datadoghq.atlassian.net/browse/AITS-287

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

@FlorentClarret FlorentClarret changed the title florentclarret/ambari/update tests Update the test that assert external tags Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023 •
edited
Loading

Codecov Report

Merging #16091 (2e3571e) into master (e7dddf7) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Flag Coverage Δ
activemq ?
ambari 85.80% <100.00%> (+0.04%) ⬆️
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
tomcat ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@FlorentClarret FlorentClarret changed the base branch from master to florentclarret/dcd/external_tags_stub October 26, 2023 12:31
@FlorentClarret FlorentClarret force-pushed the florentclarret/dcd/external_tags_stub branch 2 times, most recently from 55dd38e to b9b09f9 Compare October 26, 2023 15:35
@FlorentClarret FlorentClarret mentioned this pull request Oct 26, 2023
Merged
3 tasks
@github-actions
Copy link

github-actions bot commented Oct 26, 2023 •
edited
Loading

Test Results

  4 files    4 suites   12s ⏱️
18 tests 17 ✔️ 1 💤 0 ❌
38 runs  34 ✔️ 4 💤 0 ❌

Results for commit 2e3571e.

♻️ This comment has been updated with latest results.

Base automatically changed from florentclarret/dcd/external_tags_stub to master October 27, 2023 09:20
@FlorentClarret FlorentClarret dismissed jose-manuel-almaza’s stale review October 27, 2023 09:20

The base branch was changed.

@FlorentClarret FlorentClarret force-pushed the florentclarret/ambari/update_tests branch from 211ae57 to 2e3571e Compare October 27, 2023 09:58
@FlorentClarret FlorentClarret marked this pull request as ready for review October 27, 2023 10:00
@FlorentClarret FlorentClarret requested a review from a team as a code owner October 27, 2023 10:00
iliakur
iliakur approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@iliakur iliakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Learned something from this!

@FlorentClarret FlorentClarret merged commit 3a59915 into master Oct 27, 2023
@FlorentClarret FlorentClarret deleted the florentclarret/ambari/update_tests branch October 27, 2023 12:03
@FlorentClarret FlorentClarret mentioned this pull request Nov 2, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iliakur iliakur iliakur approved these changes

@jose-manuel-almaza jose-manuel-almaza jose-manuel-almaza approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog integration/ambari
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FlorentClarret @iliakur @jose-manuel-almaza