-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PLINT-265] Update pyvmomi to 8.0.2.0.1 #16542
Conversation
Test Results 8 files 8 suites 7m 13s ⏱️ Results for commit 70bb3cc. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
* Update pyvmmomi * update to throw type error * change to key error * Add changelogs
* Update pyvmmomi * update to throw type error * change to key error * Add changelogs
* Update pyvmmomi * update to throw type error * change to key error * Add changelogs
What does this PR do?
Updates pyvmomi to the next major version and newest release
Motivation
Support for new API parameters added in recent releases and eventual support for vSphere 8
Additional Notes
the major upgrade to 8.x (vmware/pyvmomi@a90023f#diff-5a4a25310fcd77c939492db13158e8639be94c33532b071817930805a7be554b) includes removal of the
ParserError
class. Handling this error was added in #6658 to account for this issue.ParserError
was used as a catch-all parsing excepting inParseData
, which was removed fromDeserialize
in the new version of the library-->
This issue seems like the equivalent error thrown in pyvmomi 8.x: vmware/pyvmomi#1016. This comment from the older issue vmware/pyvmomi#190 (comment) references the
KeyError
thrown byGuessWsdlType
, which is the resulting error thrown in issue 1016. This is why I've changed our error handling to catchKeyError
s instead.Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.