New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pydantic to v2.7.3 #17781

Closed

vivek-datadog wants to merge 1 commit into master from vivek-datadog/VULN-6355-base-check-only

Contributor

vivek-datadog commented Jun 10, 2024 •

edited

Loading

What does this PR do?

Motivation

Additional Notes

Pydantic v2.7.3 update is a breaking change for datadog_checks_base. This requires datamodel-code-generator to be updated which results in the auto generated model names to be updated for multiple of integrations, it basically pluralizes the model names, for example Counter becomes Counters. So the ddev validate models will fail for this PR for all the affected integrations.

The corrective path for that is to use the to be released datadog_checks_base version (mostly v37.0.0) and then run ddev validate models to fix the integrations. Apply those changes and release all the affected integrations.

This is a case of circular dependency, we are going to solve this by allowing the master pipeline to be in an unstable state (i.e., failing pipelines) for few hours till this is resolved.

Review checklist (to be filled by reviewers)

Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
Changelog entries must be created for modifications to shipped code
Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

datadog-agent-integrations-bot bot added documentation dependencies dev_package base_package ddev labels

github-actions bot commented Jun 10, 2024

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

1 similar comment

github-actions bot commented Jun 10, 2024

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

vivek-datadog added the backport/7.55.x label

vivek-datadog marked this pull request as ready for review

June 10, 2024 14:46

vivek-datadog requested review from a team as code owners

June 10, 2024 14:46

github-actions bot commented Jun 10, 2024

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

datadog-agent-integrations-bot bot added team/agent-integrations team/documentation labels

github-actions bot commented Jun 10, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

github-actions bot commented Jun 10, 2024

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.


          Update pydantic to v2.7.3

acdc9ef

vivek-datadog force-pushed the vivek-datadog/VULN-6355-base-check-only branch from 00f94ca to acdc9ef Compare

June 10, 2024 14:50

github-actions bot commented Jun 10, 2024

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

steveny91 approved these changes

View reviewed changes

github-actions bot commented Jun 10, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

codecov bot commented Jun 10, 2024 •

edited

Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.28%. Comparing base (f800fbf) to head (acdc9ef).
Report is 4 commits behind head on master.

Additional details and impacted files

Flag	Coverage Δ
active_directory	`100.00% <ø> (+27.27%)`	⬆️
activemq	`52.80% <ø> (ø)`
activemq_xml	`82.31% <ø> (ø)`
amazon_msk	`88.91% <ø> (ø)`
ambari	`85.80% <ø> (ø)`
apache	`95.08% <ø> (ø)`
arangodb	`98.23% <ø> (ø)`
argo_rollouts	`90.00% <ø> (ø)`
argo_workflows	`87.87% <ø> (ø)`
argocd	`87.81% <ø> (ø)`
aspdotnet	`100.00% <ø> (ø)`
avi_vantage	`91.35% <ø> (ø)`
azure_iot_edge	`82.08% <ø> (ø)`
boundary	`100.00% <ø> (ø)`
btrfs	`82.91% <ø> (ø)`
cacti	`87.90% <ø> (ø)`
calico	`84.61% <ø> (ø)`
cassandra	`66.66% <ø> (ø)`
cert_manager	`77.41% <ø> (ø)`
cilium	`?`
cisco_aci	`95.31% <ø> (ø)`
citrix_hypervisor	`87.50% <ø> (ø)`
cloud_foundry_api	`96.11% <ø> (ø)`
cloudera	`99.49% <ø> (ø)`
cockroachdb	`93.19% <ø> (ø)`
consul	`91.82% <ø> (ø)`
coredns	`94.61% <ø> (ø)`
couch	`?`
couchbase	`?`
crio	`89.79% <ø> (ø)`
datadog_checks_base	`89.68% <ø> (+0.84%)`	⬆️
datadog_checks_dev	`77.42% <ø> (+0.10%)`	⬆️
datadog_checks_downloader	`81.37% <ø> (ø)`
datadog_cluster_agent	`90.19% <ø> (ø)`
dcgm	`92.10% <ø> (ø)`
ddev	`87.93% <ø> (ø)`
directory	`95.46% <ø> (+0.43%)`	⬆️
disk	`89.34% <ø> (ø)`
dns_check	`93.33% <ø> (ø)`
dotnetclr	`?`
druid	`97.70% <ø> (ø)`
ecs_fargate	`83.52% <ø> (ø)`
eks_fargate	`94.05% <ø> (ø)`
envoy	`95.38% <ø> (+0.28%)`	⬆️
esxi	`92.89% <ø> (ø)`
etcd	`95.56% <ø> (ø)`
external_dns	`89.28% <ø> (ø)`
fluentd	`94.48% <ø> (ø)`
fluxcd	`88.31% <ø> (ø)`
foundationdb	`83.83% <ø> (ø)`
gearmand	`?`
gitlab_runner	`92.10% <ø> (ø)`
go_expvar	`92.73% <ø> (ø)`
gunicorn	`92.07% <ø> (ø)`
haproxy	`?`
harbor	`?`
hazelcast	`92.39% <ø> (ø)`
hdfs_datanode	`89.74% <ø> (ø)`
hdfs_namenode	`86.72% <ø> (ø)`
hive	`51.42% <ø> (ø)`
hivemq	`61.90% <ø> (ø)`
http_check	`95.32% <ø> (+2.02%)`	⬆️
hudi	`73.91% <ø> (ø)`
ibm_ace	`92.25% <ø> (?)`
ibm_db2	`86.87% <ø> (ø)`
ibm_i	`81.91% <ø> (ø)`
ibm_mq	`91.28% <ø> (ø)`
ibm_was	`?`
ignite	`46.66% <ø> (ø)`
impala	`97.97% <ø> (ø)`
istio	`78.14% <ø> (+0.51%)`	⬆️
jboss_wildfly	`47.36% <ø> (ø)`
kafka	`64.70% <ø> (ø)`
karpenter	`94.36% <ø> (ø)`
kong	`?`
kube_apiserver_metrics	`97.74% <ø> (ø)`
kube_controller_manager	`97.89% <ø> (ø)`
kube_dns	`95.97% <ø> (ø)`
kube_metrics_server	`94.87% <ø> (ø)`
kube_proxy	`96.80% <ø> (ø)`
kube_scheduler	`97.92% <ø> (ø)`
kubelet	`91.01% <ø> (ø)`
kubernetes_cluster_autoscaler	`93.22% <ø> (ø)`
kubernetes_state	`89.50% <ø> (ø)`
kyototycoon	`85.96% <ø> (ø)`
lighttpd	`83.64% <ø> (ø)`
linkerd	`85.22% <ø> (+1.13%)`	⬆️
linux_proc_extras	`96.22% <ø> (ø)`
mapr	`82.42% <ø> (ø)`
mapreduce	`82.08% <ø> (ø)`
marathon	`83.12% <ø> (ø)`
marklogic	`?`
mcache	`93.50% <ø> (ø)`
mesos_master	`89.71% <ø> (ø)`
mesos_slave	`93.31% <ø> (ø)`
mysql	`83.72% <ø> (?)`
nagios	`89.01% <ø> (ø)`
network	`93.64% <ø> (+1.08%)`	⬆️
nfsstat	`95.20% <ø> (ø)`
nginx	`95.07% <ø> (+0.53%)`	⬆️
nginx_ingress_controller	`98.36% <ø> (ø)`
nvidia_triton	`88.52% <ø> (ø)`
openldap	`96.33% <ø> (ø)`
openmetrics	`98.08% <ø> (ø)`
openstack	`55.19% <ø> (ø)`
openstack_controller	`94.23% <ø> (ø)`
pgbouncer	`91.35% <ø> (ø)`
php_fpm	`90.53% <ø> (+0.82%)`	⬆️
postfix	`88.10% <ø> (ø)`
postgres	`?`
powerdns_recursor	`96.65% <ø> (ø)`
presto	`59.09% <ø> (ø)`
process	`85.28% <ø> (+0.28%)`	⬆️
prometheus	`94.17% <ø> (ø)`
proxysql	`98.97% <ø> (ø)`
pulsar	`100.00% <ø> (ø)`
ray	`96.45% <ø> (ø)`
redisdb	`?`
rethinkdb	`97.93% <ø> (ø)`
riak	`99.21% <ø> (ø)`
riakcs	`93.61% <ø> (ø)`
scylla	`?`
silk	`93.82% <ø> (ø)`
singlestore	`90.81% <ø> (ø)`
snowflake	`96.27% <ø> (ø)`
solr	`56.25% <ø> (ø)`
spark	`94.14% <ø> (ø)`
squid	`100.00% <ø> (ø)`
statsd	`87.36% <ø> (ø)`
strimzi	`89.78% <ø> (ø)`
supervisord	`89.78% <ø> (ø)`
system_core	`92.66% <ø> (ø)`
system_swap	`98.30% <ø> (ø)`
tcp_check	`91.58% <ø> (ø)`
teamcity	`88.57% <ø> (+3.17%)`	⬆️
tekton	`82.30% <ø> (ø)`
teleport	`99.61% <ø> (ø)`
temporal	`100.00% <ø> (ø)`
teradata	`94.05% <ø> (ø)`
tls	`92.02% <ø> (+0.86%)`	⬆️
tokumx	`57.52% <ø> (ø)`
tomcat	`60.41% <ø> (?)`
torchserve	`97.32% <ø> (ø)`
traefik_mesh	`76.75% <ø> (ø)`
traffic_server	`96.13% <ø> (ø)`
twemproxy	`79.56% <ø> (ø)`
twistlock	`80.47% <ø> (ø)`
varnish	`84.39% <ø> (+0.26%)`	⬆️
vault	`?`
voltdb	`?`
vsphere	`?`
weaviate	`76.27% <ø> (ø)`
win32_event_log	`82.67% <ø> (+1.11%)`	⬆️
wmi_check	`97.50% <ø> (ø)`
yarn	`89.52% <ø> (ø)`
zk	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

rtrieu approved these changes

View reviewed changes

Contributor

rtrieu left a comment

Looks good!

Kyle-Neale approved these changes

View reviewed changes

Contributor Author

vivek-datadog commented Jun 12, 2024

Will be taken care with #17802

vivek-datadog closed this

vivek-datadog deleted the vivek-datadog/VULN-6355-base-check-only branch

June 12, 2024 12:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/7.55.x base_package ddev dependencies dev_package documentation team/agent-integrations team/documentation