Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SAASINT-3328] DDS: Avast: Crawler Integration Without Assets #18911

Merged
merged 9 commits into from
Jan 30, 2025

Conversation

narendranandaniya-crest
Copy link
Contributor

What does this PR do?

PR includes skeleton of Avast integration without any assets like dashboards, image, README content, etc.

Motivation

This is beta release of crawler integration and is intended for internal testing before going live. As per @nathanandersen's suggestion, we are planning to raise separate PR with assets and all necessary information later.

Additional Notes

Only crawler-based integration related changes are included in this PR.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@narendranandaniya-crest narendranandaniya-crest changed the title DDS: Avast: Crawler Integration v1.0.0 DDS: Avast: Crawler Integration Without Assets Oct 25, 2024
buraizu
buraizu previously approved these changes Nov 6, 2024
Copy link
Contributor

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with one suggestion to correct a minor inconsistency

"configuration": "README.md#Setup",
"support": "README.md#Support",
"changelog": "CHANGELOG.md",
"description": "Gain insights into avast logs.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description": "Gain insights into avast logs.",
"description": "Gain insights into Avast logs.",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@torosmassa torosmassa changed the title DDS: Avast: Crawler Integration Without Assets [SAASINT-3328] DDS: Avast: Crawler Integration Without Assets Dec 18, 2024
@lli-datadog
Copy link
Contributor

@narendranandaniya-crest can you resolve conflict? I will merge it once that's done

@lli-datadog
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 30, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-30 14:55:22 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-01-30 18:56:06 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@lli-datadog lli-datadog added this pull request to the merge queue Jan 30, 2025
Merged via the queue into DataDog:master with commit fa78c3c Jan 30, 2025
49 of 52 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 30, 2025
* initial commit

* updated tile descrption

* Update CODEOWNERS

---------

Co-authored-by: Abhi Shah <[email protected]> fa78c3c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants