-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SAASINT-3328] DDS: Avast: Crawler Integration Without Assets #18911
[SAASINT-3328] DDS: Avast: Crawler Integration Without Assets #18911
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with one suggestion to correct a minor inconsistency
avast/manifest.json
Outdated
"configuration": "README.md#Setup", | ||
"support": "README.md#Support", | ||
"changelog": "CHANGELOG.md", | ||
"description": "Gain insights into avast logs.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"description": "Gain insights into avast logs.", | |
"description": "Gain insights into Avast logs.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
@narendranandaniya-crest can you resolve conflict? I will merge it once that's done |
/merge |
Devflow running:
|
* initial commit * updated tile descrption * Update CODEOWNERS --------- Co-authored-by: Abhi Shah <[email protected]> fa78c3c
What does this PR do?
PR includes skeleton of Avast integration without any assets like dashboards, image, README content, etc.
Motivation
This is beta release of crawler integration and is intended for internal testing before going live. As per @nathanandersen's suggestion, we are planning to raise separate PR with assets and all necessary information later.
Additional Notes
Only crawler-based integration related changes are included in this PR.
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged