Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mongo] add config option to enable search indexes collection #19396

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

lu-zhengda
Copy link
Contributor

What does this PR do?

This PR introduces a configuration option to control the collection of MongoDB Atlas search indexes via the $listSearchIndexes aggregation pipeline. By default, this feature is now disabled.

Motivation

The change is motivated by performance considerations, as the $listSearchIndexes aggregation can run slowly and impact database performance.

https://datadoghq.atlassian.net/browse/DBMON-4910

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@lu-zhengda lu-zhengda added the qa/skip-qa Automatically skip this PR for the next QA label Jan 14, 2025
@lu-zhengda lu-zhengda changed the title [mongo] disable search indexes collection [mongo] add config option to enable search indexes collection Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.56%. Comparing base (c31d8c2) to head (4920dad).
Report is 7 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
mongo 93.00% <100.00%> (-0.81%) ⬇️
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@lu-zhengda lu-zhengda marked this pull request as ready for review January 14, 2025 18:56
@lu-zhengda lu-zhengda requested review from a team as code owners January 14, 2025 18:56
@lu-zhengda lu-zhengda added this pull request to the merge queue Jan 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 15, 2025
@lu-zhengda lu-zhengda added this pull request to the merge queue Jan 15, 2025
Merged via the queue into master with commit 5dc1c5c Jan 15, 2025
35 checks passed
@lu-zhengda lu-zhengda deleted the zhengda.lu/search-idx branch January 15, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants