Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update istio to use the new OpenMetricsBaseCheck #1979

Merged
merged 2 commits into from
Aug 31, 2018
Merged

Update istio to use the new OpenMetricsBaseCheck #1979

merged 2 commits into from
Aug 31, 2018

Conversation

rishabh
Copy link

@rishabh rishabh commented Aug 2, 2018 •
edited
Loading

What does this PR do?

Updates istio to use the new OpenMetricsBaseCheck class.

Motivation

This fixes the check for when we use the new OpenMetricsBaseCheck class.

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

Additional Notes

@rishabh rishabh requested a review from a team as a code owner August 2, 2018 19:40
@rishabh rishabh force-pushed the rish/prometheus_rework branch from e7b150c to 55edc20 Compare August 3, 2018 02:05
@rishabh rishabh force-pushed the rish/istio-prometheus-rework branch from 85c7ae5 to 7abfc65 Compare August 3, 2018 03:23
@l0k0ms l0k0ms mentioned this pull request Aug 3, 2018
Merged
4 tasks
@rishabh rishabh force-pushed the rish/prometheus_rework branch 2 times, most recently from 934661a to be99352 Compare August 7, 2018 21:57
@rishabh rishabh force-pushed the rish/istio-prometheus-rework branch 2 times, most recently from 1857549 to a61704c Compare August 7, 2018 22:24
@rishabh rishabh force-pushed the rish/prometheus_rework branch from be99352 to d5b1cdb Compare August 8, 2018 18:44
@rishabh rishabh force-pushed the rish/istio-prometheus-rework branch 3 times, most recently from 163e846 to 394683d Compare August 9, 2018 15:10
@rishabh rishabh changed the title Update istio to use the new GenericPrometheusCheck Update istio to use the new OpenMetricsBaseCheck Aug 9, 2018
@rishabh rishabh force-pushed the rish/prometheus_rework branch 2 times, most recently from 222cee3 to 7bde919 Compare August 21, 2018 20:50
@rishabh rishabh changed the base branch from rish/prometheus_rework to master August 30, 2018 21:06
@rishabh rishabh force-pushed the rish/istio-prometheus-rework branch from 394683d to bb3362a Compare August 30, 2018 21:06
gmmeyer
gmmeyer previously approved these changes Aug 30, 2018
View reviewed changes
Copy link
Contributor

@gmmeyer gmmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great to me! thanks a lot! make sure the tests pass before you merge

@rishabh rishabh force-pushed the rish/istio-prometheus-rework branch from d14f587 to 91f707d Compare August 31, 2018 18:44
@rishabh rishabh force-pushed the rish/istio-prometheus-rework branch from 91f707d to 40cc684 Compare August 31, 2018 18:45
@rishabh rishabh merged commit 25a950d into master Aug 31, 2018
@rishabh rishabh deleted the rish/istio-prometheus-rework branch August 31, 2018 19:27
nmuesch pushed a commit that referenced this pull request Nov 1, 2018
@nmuesch
Update istio to use the new OpenMetricsBaseCheck (#1979)
bf2ceb9 
* Use OpenMetricsBaseCheck
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmmeyer gmmeyer gmmeyer approved these changes

@nmuesch nmuesch nmuesch approved these changes

Assignees
No one assigned
Labels
integration/istio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rishabh @gmmeyer @nmuesch