Fix job metrics tagging on KSM 1.4+ #2384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dabcoder
force-pushed
the
davidb/ksm-job-name-fix
branch
from
4e6a2f5 to
4e28a53
Compare
Codecov Report
@@ Coverage Diff @@
## master #2384 +/- ##
==========================================
+ Coverage 79.58% 82.44% +2.85%
==========================================
Files 205 4 -201
Lines 13786 376 -13410
Branches 1460 72 -1388
==========================================
- Hits 10972 310 -10662
+ Misses 2422 45 -2377
+ Partials 392 21 -371 |
dabcoder
force-pushed
the
davidb/ksm-job-name-fix
branch
4 times, most recently
from
fd1c41e to
b0507ee
Compare
dabcoder
force-pushed
the
davidb/ksm-job-name-fix
branch
from
b0507ee to
7d9a778
Compare
xvello
approved these changes
Oct 11, 2018
xvello
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
KSM 1.4.0 changed the
joblabel tojob_name, handle this.Motivation
The pods created by the jobs were tagged and not the jobs themselves.
Review checklist
no-changeloglabel attached