Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump kafka-python and kazoo #2766

Merged
merged 1 commit into from
Dec 17, 2018
Merged

Bump kafka-python and kazoo #2766

merged 1 commit into from
Dec 17, 2018

Conversation

masci
Copy link
Contributor

@masci masci commented Dec 17, 2018

What does this PR do?

Per kafka_consumer check requirements.

Sister PRs (hold until those are merged):

Motivation

Requirements bumped in #2728 and #2729

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
  • If PR adds a configuration option, it has been added to the configuration file.

@codecov-io
Copy link

codecov-io commented Dec 17, 2018

Codecov Report

Merging #2766 into master will decrease coverage by 9.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2766      +/-   ##
==========================================
- Coverage   84.71%   75.63%   -9.08%     
==========================================
  Files         657       45     -612     
  Lines       37482     3263   -34219     
  Branches     4506      386    -4120     
==========================================
- Hits        31753     2468   -29285     
+ Misses       4407      699    -3708     
+ Partials     1322       96    -1226

@masci masci requested a review from a team December 17, 2018 09:46
Copy link
Member

@olivielpeau olivielpeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping, please make related changes to the Agent 5 build:

I've checked the Agent 6 build and it doesn't seem to define these deps separately (i.e. they don't appear here: https://github.com/DataDog/datadog-agent/blob/6.8.0/omnibus/config/software/datadog-agent-integrations.rb#L11-L24)

@masci masci merged commit 2bec564 into master Dec 17, 2018
@masci masci deleted the massi/bump-kafka branch December 17, 2018 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants