Do not append duplicates when using device_name parameter.
#2850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zippolyte
previously approved these changes
Jan 2, 2019
gzussa
previously approved these changes
Jan 2, 2019
ofek
requested changes
Jan 2, 2019
| normalized_tags = self._normalize_tags_type(tags) | ||
|
|
||
| return normalized_tags | ||
| return self._normalize_tags_type(out_tags) |
There was a problem hiding this comment.
To avoid double list creation, let's just revert to working commit here:
integrations-core/datadog_checks_base/datadog_checks/base/checks/base.py
Lines 321 to 327 in 8bb1983
There was a problem hiding this comment.
another solution could be
t = copy.deepcopy(tags)
if device_name:
self._log_deprecation("device_name")
t.append("device:{}".format(device_name))
normalized_tags = self._normalize_tags_type(t)
return normalized_tags```
There was a problem hiding this comment.
@ofek The point is to also normalize the device tag, so we can't really go back to this
gzussa
reviewed
Jan 3, 2019
| normalized_tags.append(tag) | ||
|
|
||
| return normalized_tags | ||
|
|
||
| def _normalize_type(self, data): |
There was a problem hiding this comment.
Could we rename this to reflect more what it does _encode_to_bytes or _to_bytes?
Codecov Report
@@ Coverage Diff @@
## master #2850 +/- ##
==========================================
- Coverage 84.48% 76.99% -7.49%
==========================================
Files 630 50 -580
Lines 36958 3582 -33376
Branches 4416 414 -4002
==========================================
- Hits 31223 2758 -28465
+ Misses 4434 724 -3710
+ Partials 1301 100 -1201 |
zippolyte
approved these changes
Jan 3, 2019
ofek
approved these changes
Jan 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Avoids appending multiple times the same tag when the (deprecated)
device_nameparam is used. This will also fix tests onmaster.PR is marked as
no-changelogbecause the commit that introduced the bug (#2822) hasn't been released yet.Motivation
Avoid sending fatter payloads because of duplicates
Review checklist
no-changeloglabel attached