Include count as an aggregate type in tests #2920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2920 +/- ##
==========================================
- Coverage 84.67% 75.59% -9.08%
==========================================
Files 648 53 -595
Lines 36185 3897 -32288
Branches 4317 470 -3847
==========================================
- Hits 30640 2946 -27694
+ Misses 4278 829 -3449
+ Partials 1267 122 -1145 |
Codecov Report
@@ Coverage Diff @@
## master #2920 +/- ##
==========================================
- Coverage 84.67% 84.45% -0.23%
==========================================
Files 648 645 -3
Lines 36185 37808 +1623
Branches 4317 4540 +223
==========================================
+ Hits 30640 31931 +1291
- Misses 4278 4530 +252
- Partials 1267 1347 +80 |
zippolyte
approved these changes
Jan 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
https://github.com/DataDog/datadog-agent/blob/f07a569ba1114b91a33401a4465f43d9189057cc/pkg/metrics/count.go#L8-L9