Expose the single check instance as an attribute #3093
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3093 +/- ##
==========================================
- Coverage 84.28% 75.29% -8.99%
==========================================
Files 668 47 -621
Lines 36107 3578 -32529
Branches 4283 427 -3856
==========================================
- Hits 30431 2694 -27737
+ Misses 4432 776 -3656
+ Partials 1244 108 -1136 |
| @@ -89,6 +89,9 @@ def __init__(self, *args, **kwargs): | |||
| # new-style init: the 3rd argument is `instances` | |||
| self.instances = args[2] | |||
|
|
|||
| # Agent 6+ will only have one instance | |||
There was a problem hiding this comment.
Why would agent 6+ only have one instance?
There was a problem hiding this comment.
Because there is a new AgentCheck instantiated for every check instance cc @olivielpeau or @truthbk maybe can confirm
There was a problem hiding this comment.
this is correct, since v6.0 the Agent instantiates one instance of the AgentCheck class per configured instance of the check. Relevant code: https://github.com/DataDog/datadog-agent/blob/6.9.0/pkg/collector/py/loader.go#L243-L255
There was a problem hiding this comment.
ok i wasn't aware of this. Thanks for the update.
| @@ -89,6 +89,9 @@ def __init__(self, *args, **kwargs): | |||
| # new-style init: the 3rd argument is `instances` | |||
| self.instances = args[2] | |||
|
|
|||
| # Agent 6+ will only have one instance | |||
There was a problem hiding this comment.
ok i wasn't aware of this. Thanks for the update.
Motivation
Easier access to the instance (for new checks) so you don't have to pass it around everywhere