Fix openmetrics mixins telemetry metrics #4155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandreYang
previously approved these changes
Jul 19, 2019
AlexandreYang
approved these changes
Jul 19, 2019
Codecov Report
@@ Coverage Diff @@
## master #4155 +/- ##
==========================================
- Coverage 87.59% 84.54% -3.06%
==========================================
Files 521 69 -452
Lines 27420 5415 -22005
Branches 3120 675 -2445
==========================================
- Hits 24019 4578 -19441
+ Misses 2574 683 -1891
+ Partials 827 154 -673 |
6 similar comments
Codecov Report
@@ Coverage Diff @@
## master #4155 +/- ##
==========================================
- Coverage 87.59% 84.54% -3.06%
==========================================
Files 521 69 -452
Lines 27420 5415 -22005
Branches 3120 675 -2445
==========================================
- Hits 24019 4578 -19441
+ Misses 2574 683 -1891
+ Partials 827 154 -673 |
Codecov Report
@@ Coverage Diff @@
## master #4155 +/- ##
==========================================
- Coverage 87.59% 84.54% -3.06%
==========================================
Files 521 69 -452
Lines 27420 5415 -22005
Branches 3120 675 -2445
==========================================
- Hits 24019 4578 -19441
+ Misses 2574 683 -1891
+ Partials 827 154 -673 |
Codecov Report
@@ Coverage Diff @@
## master #4155 +/- ##
==========================================
- Coverage 87.59% 84.54% -3.06%
==========================================
Files 521 69 -452
Lines 27420 5415 -22005
Branches 3120 675 -2445
==========================================
- Hits 24019 4578 -19441
+ Misses 2574 683 -1891
+ Partials 827 154 -673 |
Codecov Report
@@ Coverage Diff @@
## master #4155 +/- ##
==========================================
- Coverage 87.59% 84.54% -3.06%
==========================================
Files 521 69 -452
Lines 27420 5415 -22005
Branches 3120 675 -2445
==========================================
- Hits 24019 4578 -19441
+ Misses 2574 683 -1891
+ Partials 827 154 -673 |
Codecov Report
@@ Coverage Diff @@
## master #4155 +/- ##
==========================================
- Coverage 87.59% 84.54% -3.06%
==========================================
Files 521 69 -452
Lines 27420 5415 -22005
Branches 3120 675 -2445
==========================================
- Hits 24019 4578 -19441
+ Misses 2574 683 -1891
+ Partials 827 154 -673 |
Codecov Report
@@ Coverage Diff @@
## master #4155 +/- ##
==========================================
- Coverage 87.59% 84.54% -3.06%
==========================================
Files 521 69 -452
Lines 27420 5415 -22005
Branches 3120 675 -2445
==========================================
- Hits 24019 4578 -19441
+ Misses 2574 683 -1891
+ Partials 827 154 -673 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix the openmetrics mixins telemetry metrics.
Motivation
in previous version instead of counting the number of metrics, we only count the number of metrics family.
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached