Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add requests wrapper to mesos_slave #4222

Merged
merged 17 commits into from
Aug 21, 2019
Merged

Add requests wrapper to mesos_slave #4222

merged 17 commits into from
Aug 21, 2019

Conversation

ChristineTChen
Copy link
Contributor

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • Feature or bugfix must have tests
  • Git history must be clean
  • If PR adds a configuration option, it must be added to the configuration file.

@ChristineTChen ChristineTChen requested review from a team as code owners July 29, 2019 01:01
@codecov
Copy link

codecov bot commented Jul 29, 2019 •
edited
Loading

Codecov Report

Merging #4222 into master will increase coverage by 5.46%.
The diff coverage is 92.18%.

Impacted file tree graph

Impacted Files Coverage Δ
mesos_slave/tests/conftest.py 100% <100%> (ø)
mesos_slave/tests/utils.py 100% <100%> (ø)
mesos_slave/tests/test_check.py 100% <100%> (ø)
mesos_slave/tests/test_integration.py 100% <100%> (ø)
...os_slave/datadog_checks/mesos_slave/mesos_slave.py 69.84% <79.16%> (ø)
disk/datadog_checks/disk/__init__.py
...checks_dev/tests/plugin/test_environment_runner.py
datadog_checks_base/tests/test_similar.py
win32_event_log/tests/test_check.py
...service/datadog_checks/windows_service/__init__.py
... and 164 more

hithwen
hithwen previously approved these changes Jul 29, 2019
View reviewed changes
AlexandreYang
AlexandreYang requested changes Jul 29, 2019
View reviewed changes
Copy link
Member

@AlexandreYang AlexandreYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment about default_timeout, otherwise looks fine.

mesos_slave/datadog_checks/mesos_slave/mesos_slave.py Show resolved Hide resolved
@ChristineTChen ChristineTChen force-pushed the christine/mesos_slave-requests branch from 974f972 to f673c87 Compare August 5, 2019 18:25
@ChristineTChen ChristineTChen force-pushed the christine/mesos_slave-requests branch from 4e3e99e to 453012e Compare August 7, 2019 17:45
@hithwen hithwen requested review from ofek and AlexandreYang August 8, 2019 08:03
ofek
ofek requested changes Aug 15, 2019
View reviewed changes
mesos_slave/tests/conftest.py Outdated Show resolved Hide resolved
@ChristineTChen ChristineTChen force-pushed the christine/mesos_slave-requests branch from 2536cda to c54d991 Compare August 19, 2019 18:57
ruthnaebeck
ruthnaebeck suggested changes Aug 19, 2019
View reviewed changes
Copy link
Contributor

@ruthnaebeck ruthnaebeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs review

mesos_slave/datadog_checks/mesos_slave/data/conf.yaml.example Outdated Show resolved Hide resolved
mesos_slave/datadog_checks/mesos_slave/data/conf.yaml.example Outdated Show resolved Hide resolved
mesos_slave/datadog_checks/mesos_slave/data/conf.yaml.example Outdated Show resolved Hide resolved
ruthnaebeck
ruthnaebeck approved these changes Aug 19, 2019
View reviewed changes
Copy link
Contributor

@ruthnaebeck ruthnaebeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for docs

AlexandreYang
AlexandreYang approved these changes Aug 21, 2019
View reviewed changes
Copy link
Member

@AlexandreYang AlexandreYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChristineTChen ChristineTChen merged commit eda40ee into master Aug 21, 2019
@ChristineTChen ChristineTChen deleted the christine/mesos_slave-requests branch August 21, 2019 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorianVeaux FlorianVeaux FlorianVeaux left review comments

@ofek ofek ofek requested changes

@ruthnaebeck ruthnaebeck ruthnaebeck approved these changes

@AlexandreYang AlexandreYang AlexandreYang approved these changes

@hithwen hithwen hithwen left review comments

Assignees
No one assigned
Labels
integration/mesos_slave
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ChristineTChen @hithwen @ofek @ruthnaebeck @FlorianVeaux @AlexandreYang