Extract version utils and use semver for version comparison #4844
Conversation
Codecov Report
|
hithwen
force-pushed
the
julia/pg-refactor-use-semver
branch
from
6e6ed59 to
6b3af0d
Compare
hithwen
changed the title
hithwen
force-pushed
the
julia/pg-refactor-use-semver
branch
from
eafc603 to
fb0cba8
Compare
| return semver.VersionInfo(*version) | ||
| except Exception: | ||
| # Postgres might be in development, with format \d+[beta|rc]\d+ | ||
| match = re.match(r'(\d+)([a-zA-Z]+)(\d+)', raw_version) |
There was a problem hiding this comment.
I don't know. PG documentation only refers to actual releases, which are on X.Y.Z format https://www.postgresql.org/support/versioning/
There was a problem hiding this comment.
According to https://github.com/postgres/postgres/releases/, postgres seems to follow semver, only betas differ from semver and they seem to only apply to major versions:
For example: postgres/postgres@a240570#diff-e2d5a00791bce9a01f99bc6fd613a39dR585
We need to pass the requirements explicitly when updating a check to its development version.
…lia/pg-refactor-use-semver
| def _is_10_or_above(self): | ||
| return self._is_above([10, 0, 0]) | ||
| @property | ||
| def version(self): |
There was a problem hiding this comment.
We shouldn't cache version information as it may change
There was a problem hiding this comment.
The cache is cleared when wrong version is detected (see _clean_state). Take into account we are already caching version specific information such as which queries to run
There was a problem hiding this comment.
It's only cleared when an error occurs and the difference between minor releases is unlikely to cause one
There was a problem hiding this comment.
Ok, that is right and that would affect inventories project only. So I'll remove the caching as part of the PR that adds inventories. This PR is not intending to change behaviour and version was already cached (#4874 (comment))
| return semver.VersionInfo(*version) | ||
| except Exception: | ||
| # Postgres might be in development, with format \d+[beta|rc]\d+ | ||
| match = re.match(r'(\d+)([a-zA-Z]+)(\d+)', raw_version) |
There was a problem hiding this comment.
According to https://github.com/postgres/postgres/releases/, postgres seems to follow semver, only betas differ from semver and they seem to only apply to major versions:
For example: postgres/postgres@a240570#diff-e2d5a00791bce9a01f99bc6fd613a39dR585
AlexandreYang
changed the title
Use semver for version comparison, extract version_utils
There is another PR after this to submit version metadata