Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade vertica to stop logging to /dev/null #5352

Merged
merged 5 commits into from
Jan 3, 2020
Merged

Upgrade vertica to stop logging to /dev/null #5352

merged 5 commits into from
Jan 3, 2020

Conversation

AlexandreYang
Copy link
Member

@AlexandreYang AlexandreYang commented Dec 30, 2019 •
edited
Loading

What does this PR do?

Upgrade vertica to stop logging to /dev/null

Related upstream PR: vertica/vertica-python#352

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@AlexandreYang AlexandreYang requested a review from a team as a code owner December 30, 2019 12:26
therve
therve requested changes Dec 30, 2019
View reviewed changes
vertica/datadog_checks/vertica/vertica.py Show resolved Hide resolved
vertica/requirements.in Show resolved Hide resolved
@AlexandreYang AlexandreYang force-pushed the alex/vertica_upgrade_lib branch from 0c8f014 to e4f3724 Compare December 30, 2019 12:44
@AlexandreYang AlexandreYang requested review from a team as code owners December 30, 2019 12:45
therve
therve previously approved these changes Dec 30, 2019
View reviewed changes
@codecov
Copy link

codecov bot commented Dec 30, 2019 •
edited
Loading

Codecov Report

Merging #5352 into master will decrease coverage by 0.46%.
The diff coverage is 83.33%.

Impacted Files Coverage Δ
vertica/tests/common.py 100% <ø> (ø)
vertica/datadog_checks/vertica/vertica.py 90.62% <100%> (ø)
vertica/tests/test_unit.py 100% <100%> (ø)
vertica/tests/test_vertica.py 82.92% <80%> (ø)
...e/datadog_checks/base/checks/openmetrics/mixins.py 74.2% <0%> (-4.87%) ⬇️
.../datadog_checks/base/checks/prometheus/__init__.py 100% <0%> (ø) ⬆️
...ase/datadog_checks/base/utils/subprocess_output.py 0% <0%> (ø) ⬆️
...dog_checks_base/datadog_checks/base/checks/base.py 80.16% <0%> (ø) ⬆️
...ts/tooling/configuration/consumers/test_example.py
...checks_dev/tests/plugin/test_environment_runner.py
... and 807 more

@AlexandreYang AlexandreYang changed the title Upgrade vertica to stop logging to /dev/null [WIP9] Upgrade vertica to stop logging to /dev/null Jan 1, 2020
@AlexandreYang AlexandreYang changed the title [WIP9] Upgrade vertica to stop logging to /dev/null [WIP] Upgrade vertica to stop logging to /dev/null Jan 1, 2020
@AlexandreYang AlexandreYang changed the title [WIP] Upgrade vertica to stop logging to /dev/null Upgrade vertica to stop logging to /dev/null Jan 1, 2020
ofek
ofek previously approved these changes Jan 3, 2020
View reviewed changes
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

vertica/tests/test_vertica.py Outdated Show resolved Hide resolved
@AlexandreYang AlexandreYang merged commit 7ec57dd into master Jan 3, 2020
@AlexandreYang AlexandreYang deleted the alex/vertica_upgrade_lib branch January 3, 2020 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofek ofek ofek approved these changes

@therve therve therve left review comments

Assignees
No one assigned
Labels
dependencies integration/datadog_checks_base integration/vertica
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexandreYang @therve @ofek