Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple context states for RequestsWrapper #5410

Closed
wants to merge 2 commits into from
Closed

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Jan 8, 2020

Motivation

Necessary for use in OpenMetrics base class where there are different configurations for each endpoint

Additional Notes

#5249 (comment)
#5249 (comment)

@codecov
Copy link

codecov bot commented Jan 8, 2020

Copy link
Member

@AlexandreYang AlexandreYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Could you add a desc to the PR to explain what this feature does and what's the issue or use case it's solving.

  2. I think a similar desc should also be added as docstring of RequestsWrapper with an example.

This will help current/future readers who want to understand how this feature works.

@ofek
Copy link
Contributor Author

ofek commented Jan 8, 2020

The use case is so niche that we'll do it where needed instead #5414

@ofek ofek closed this Jan 8, 2020
@ofek ofek deleted the ofek/h branch January 8, 2020 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants