Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor traced decorator and remove wrapt import #5586

Merged
merged 3 commits into from
Jan 29, 2020

Conversation

AlexandreYang
Copy link
Member

@AlexandreYang AlexandreYang commented Jan 29, 2020

What does this PR do?

  • Fix wrapt import by using @functools.wraps instead
  • Add tests

The issue appeared on CI https://dev.azure.com/datadoghq/integrations-core/_build/results?buildId=7793&view=logs&j=12f53639-7e0c-506b-2b53-a7405df1086b&t=72d0428d-576e-5e1b-640d-0ea2f62b0022

when we upgraded dd-trace: #5491

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@codecov
Copy link

codecov bot commented Jan 29, 2020

Codecov Report

Merging #5586 into master will increase coverage by 0.34%.
The diff coverage is 100%.

Impacted Files Coverage Δ
...hecks/openstack_controller/openstack_controller.py 74.08% <100%> (ø)
linkerd/tests/conftest.py 61.53% <0%> (ø) ⬆️
kubelet/datadog_checks/kubelet/prometheus.py 80.87% <0%> (ø) ⬆️
postfix/tests/test_integration.py 100% <0%> (ø) ⬆️
istio/datadog_checks/istio/__init__.py 100% <0%> (ø) ⬆️
gearmand/tests/test_integration.py 100% <0%> (ø) ⬆️
...datadog_checks/kube_controller_manager/__init__.py 100% <0%> (ø) ⬆️
go_expvar/tests/test_e2e.py 40% <0%> (ø) ⬆️
...tadog_checks/nginx_ingress_controller/__about__.py 100% <0%> (ø) ⬆️
crio/datadog_checks/crio/__about__.py 100% <0%> (ø) ⬆️
... and 879 more

@AlexandreYang AlexandreYang changed the title [POC] Remove wrapt Refactor traced decorator and remove wrapt import Jan 29, 2020
This was referenced Jan 29, 2020
brettlangdon
brettlangdon previously approved these changes Jan 29, 2020
Copy link
Member

@brettlangdon brettlangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ofek
ofek previously approved these changes Jan 29, 2020
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!!

@AlexandreYang AlexandreYang dismissed stale reviews from ofek and brettlangdon via 16630ba January 29, 2020 16:22
@AlexandreYang AlexandreYang merged commit 44e64b6 into master Jan 29, 2020
@AlexandreYang AlexandreYang deleted the alex/openstack_fix3 branch January 29, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants