Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple properties in tag_by #6614

Merged
merged 5 commits into from
May 26, 2020
Merged

Conversation

ian28223
Copy link
Contributor

What does this PR do?

Allow for multiple comma-separated properties in tag_by

Motivation

Additional Notes

  • It works as it is and there might be a better way. I just can't fully grasp the WMI check; also why there's no test

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ian28223 ian28223 requested a review from a team as a code owner May 12, 2020 02:00
@ian28223 ian28223 requested a review from ofek May 26, 2020 00:19
@ofek ofek merged commit cc02738 into master May 26, 2020
@ofek ofek deleted the ian.bucad/WMI_multiple_tagby branch May 26, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants