-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make max file count configurable in the directory check #6847
Conversation
I wanted to monitor more than 20 files and expected this setting to be configureable like in our [rabbitmq check](https://github.com/DataDog/integrations-core/blob/master/rabbitmq/datadog_checks/rabbitmq/rabbitmq.py#L183-L187) and the [jmx fetch based integrations](https://github.com/DataDog/jmxfetch/blob/master/src/main/java/org/datadog/jmxfetch/Instance.java#L64)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Let's fix up title, etc. https://datadoghq.dev/integrations-core/guidelines/pr/
forgot self when referencing the max constant in the default value Co-authored-by: Christine Chen <[email protected]>
thanks for the reviews! I updated the PR title, and updated the reference to that max constant |
@nicholas-devlin looks good to me, I'm ready to ✅ . CI is failing because of style. Please run |
Codecov Report
|
I couldn't figure out how to run that command: $ ddev test directory -fs
Code formatting is not enabled!
To enabled it, put `dd_check_style = true` under the `[testenv]` section of `tox.ini`. nothing seems to happen when i run the test without the $ ddev test
Nothing to test! I don't really understand the error that the |
@nicholas-devlin Show |
What does this PR do?
makes max_filegauge_count an undocumented configurable setting
Motivation
I wanted to monitor more than 20 files and expected this setting to be configureable like in our rabbitmq check and the jmx fetch based integrations
Additional Notes
I'm not sure if any unit tests or things also need to be updated, just let me know if so.
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached