Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue check execution when only a few vhosts are unhealthy #6954

Merged

Conversation

FlorianVeaux
Copy link
Member

Currently the check for aliveness-test was failing the whole check whenever a single vhost was reporting unhealthy (a non 2xx status code).

This PR fixes that behavior by gracefully handling the error, marking that vhost unhealthy but continuing the rest of the execution.

@FlorianVeaux FlorianVeaux changed the title Continue check execution when only a few hosts are unhealthy Continue check execution when only a few vhosts are unhealthy Jun 23, 2020
@FlorianVeaux FlorianVeaux merged commit c83b4c1 into master Jun 24, 2020
@FlorianVeaux FlorianVeaux deleted the florian/rabbitmq_ont_fail_on_single_vhost_error branch June 24, 2020 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants