Add support for etcd logs #7431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
run `ddev env start etcd py38-3.3.10 -e DD_LOGS_ENABLED=true -e DD_LOGS_CONFIG_CONTAINER_COLLECT_ALL=true`
|
style is failing |
Codecov Report
|
|
fixed the styling. |
ofek
requested changes
Aug 26, 2020
Co-authored-by: Ofek Lev <[email protected]>
Co-authored-by: Ofek Lev <[email protected]>
ofek
previously approved these changes
Aug 26, 2020
Co-authored-by: ruthnaebeck <[email protected]>
FlorianVeaux
approved these changes
Aug 27, 2020
github-actions bot
pushed a commit
that referenced
this pull request
Aug 27, 2020
* add support for etcd logs * set up test environment to forward logs run `ddev env start etcd py38-3.3.10 -e DD_LOGS_ENABLED=true -e DD_LOGS_CONFIG_CONTAINER_COLLECT_ALL=true` Co-authored-by: Ofek Lev <[email protected]> Co-authored-by: ruthnaebeck <[email protected]> 9cbc5de
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
updates readme and conf.yaml to let users know how to set up logs. Updates testing env to forward logs.
Motivation
https://datadoghq.atlassian.net/browse/AI-739
Additional Notes
https://github.com/DataDog/web-ui/pull/19132
https://github.com/DataDog/logs-backend/pull/11873
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached