Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused 'tls_load_default_certs' option #8013

Merged
merged 2 commits into from
Nov 12, 2020

Conversation

FlorianVeaux
Copy link
Member

This option isn't used yet and doesn't provide any value, there's no point in verifying the TLS connection if no CA is provided

@FlorianVeaux FlorianVeaux requested review from a team as code owners November 12, 2020 08:58
@FlorianVeaux FlorianVeaux changed the title Remove unused option Remove unused 'tls_load_default_certs' option Nov 12, 2020
Copy link
Contributor

@yzhan289 yzhan289 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@FlorianVeaux FlorianVeaux merged commit acbdc6e into master Nov 12, 2020
@FlorianVeaux FlorianVeaux deleted the florian/add_ssl_config_template branch November 12, 2020 14:33
@florimondmanca florimondmanca changed the title Remove unused 'tls_load_default_certs' option Remove unused 'tls_load_default_certs' option Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants