Add the host tag to RDS instances' parsed tags
#8292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzhan289
reviewed
Jan 6, 2021
yzhan289
previously approved these changes
Jan 6, 2021
Comment on lines
13
to
14
| * `hostname` - The full endpoint if the endpoint points to a specific instance | ||
| * `host` - The full endpoint if the endpoint points to a specific instance |
There was a problem hiding this comment.
Small nit: help distinguish hostname and host description from explanation in https://github.com/DataDog/integrations-core/pull/8292/files#r552717379.
There was a problem hiding this comment.
I moved the comment up to the docstring to disambiguate the two. Let me know if the descriptions are still unclear without additional context!
yzhan289
approved these changes
Jan 6, 2021
|
@yzhan289 any other blockers to merge + release? The CI failures look unrelated to my changes. |
|
@justiniso nope it looks good to me otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a follow-up to: #7353. A previous conversation on that PR (now removed due to a force push) suggested there may be a billing impact to adding the
hosttag to metrics. At the time, it was removed for investigation. I confirmed that host tags on metrics are not used for metering and will not impact host counts, so it is safe to add this tag back.Motivation
This tag will allow customers monitoring RDS instances to filter by
host:{rds_instance}and group byhost. Currently the tag set sent with metrics are:With this change, the tag set will be:
Additional Notes
If approved/merged, I will need help to cut a new release so postgres/mysql integrations can leverage this new functionality.
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached