Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused default config spec option #8793

Merged
merged 5 commits into from
Mar 9, 2021
Merged

Remove unused default config spec option #8793

merged 5 commits into from
Mar 9, 2021

Conversation

ChristineTChen
Copy link
Contributor

What does this PR do?

Use display_default and remove unused default options

Motivation

Follow up to #8593

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ChristineTChen ChristineTChen requested review from a team as code owners March 8, 2021 20:59
@ChristineTChen ChristineTChen changed the title Cc/display default Remove unused default config spec option Mar 8, 2021
@coignetp coignetp merged commit 606f396 into master Mar 9, 2021
@coignetp coignetp deleted the cc/display_default branch March 9, 2021 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgarabed mgarabed mgarabed approved these changes

@ofek ofek ofek approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog documentation integration/aspdotnet integration/consul integration/envoy integration/haproxy integration/http_check integration/kube_apiserver_metrics integration/kube_scheduler integration/marklogic integration/mcache integration/mesos_slave integration/pgbouncer integration/php_fpm integration/proxysql integration/supervisord integration/tcp_check integration/tokumx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChristineTChen @mgarabed @ofek @coignetp