Remove monotonic count from ignored types in no duplicate assertion #9463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more.
|
coignetp
requested changes
Jun 4, 2021
| @@ -75,8 +75,6 @@ def test_assert_no_duplicate_message(aggregator): | |||
| [ | |||
| dict(type='count', name='metric.count', value=1, tags=['aa'], hostname='1'), | |||
| dict(type='count', name='metric.count', value=1, tags=['aa'], hostname='1'), | |||
| dict(type='monotonic_count', name='metric.monotonic_count', value=1, tags=['aa'], hostname='1'), | |||
| dict(type='monotonic_count', name='metric.monotonic_count', value=1, tags=['aa'], hostname='1'), | |||
There was a problem hiding this comment.
Let's add a rate case in a duplicate metric section above
coignetp
approved these changes
Jun 9, 2021
| @@ -418,7 +418,7 @@ def assert_no_duplicate_metrics(self): | |||
| - hostname | |||
| """ | |||
| # metric types that intended to be called multiple times are ignored | |||
| ignored_types = [self.COUNT, self.MONOTONIC_COUNT, self.COUNTER] | |||
There was a problem hiding this comment.
Double submission of a monotonic_count is allowed and has a defined behaviour, however it's easily a source of error. While there is no integration submitting a monotonic_count twice on purpose, let's raise an error on these cases.
alexandre-normand
pushed a commit
that referenced
this pull request
Jun 24, 2021
…9463) * removed monotonic count from ignored types in no-duplicate assertion * added test cases for duplicate rate/monotonic count metric
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
AI-1553Additional Notes
Ideas explored to fail aggregator when this occurs:
assert_metricin tests:checkmethod is called twice in integration tests- maybe this can be asserted at the check level in tests throughassert_no_duplicate_*?dd_agent_checkfixture populates aggregator with json check output inreplay_check_run, which would result in one rate value despite duplicates (when called withrate)Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached