-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade downloader after ceremony #9556
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but need to sign, bump version number, and release, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update to latest TUF root metadata after v3 ceremony.
895327e
to
799a221
Compare
EXCLUDED_INTEGRATIONS = [ | ||
"datadog-docker-daemon", | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This integration was last released by a revoked key a few months ago. This integration was removed from integrations-core
, so it shouldn't be installable on new agents with 3.core.root.layout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, it's a bit brittle, isn't it, because how do you test new versions of this integration going forward? I recommend you get an approved key for 3.core.root.layout
to release a new version instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This integration was removed from master (#5988), it is not released anymore. It's only shipped in agent 5 so it shouldn't be installed on agent 6 or 7
Hashes of new TUF roots match expected values: > curl -fsSL https://dd-integrations-core-wheels-build-stable.datadoghq.com/metadata.staged/7.root.json | shasum -a 256
21a70e85ce8d5b5ee1283fab083e99577794d5b31add68c04b2fc8ed454d0a87 -
> curl -fsSL https://dd-integrations-core-wheels-build-stable.datadoghq.com/metadata.staged/8.root.json | shasum -a 256
ef1e2d74c5e68aabdb7edb54fb2405cd8723897f0156fd767cae2f30ccea3f14 - @coignetp or @FlorianVeaux, please double-check if you like. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there, thanks!
EXCLUDED_INTEGRATIONS = [ | ||
"datadog-docker-daemon", | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, it's a bit brittle, isn't it, because how do you test new versions of this integration going forward? I recommend you get an approved key for 3.core.root.layout
to release a new version instead.
What does this PR do?
Upgrade
tuf
,in-toto
andsecuresytemlib
to the latest version support Python 2https://github.com/theupdateframework/tuf/releases/tag/v0.17.0
https://github.com/in-toto/in-toto/blob/develop/CHANGELOG.md#v101
https://github.com/secure-systems-lab/securesystemslib/blob/master/CHANGELOG.md#securesystemslib-v0201
Motivation
Additional Notes
Hold on #9649 and #9648Removed
datadog-docker-daemon
from the test since it's an agent 5 integration moved to the agent. The wheel is no longer maintained or signed and was removed from master.Last signature was made by a revoked developer.
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached