Add db.utils.DBMAsyncJob
#9656
Merged
Add db.utils.DBMAsyncJob
#9656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
djova
force-pushed
the
djova/add-dbm-async-job
branch
from
cbeaaed to
064a664
Compare
This was referenced Jul 8, 2021
ofek
approved these changes
Jul 8, 2021
djova
added a commit
that referenced
this pull request
Jul 8, 2021
* decouple the DBM metrics collection interval from the check run interval * set default DBM metrics collection interval to 10s * change `statement_samples.collections_per_second` to `statement_samples.collection_interval` so it matches the new `statement_metrics.collection_interval` key Depends on #9656 Motivation: Being able to configure the DBM metrics collection interval separately from the check run interval enables us to use a 10 second interval (by default) for the query metrics. There are various difficulties when querying metrics that have a 15 second interval (i.e. ensuring a correct rollup window for varying time ranges) that don't exist with a 10 second interval.
djova
added a commit
that referenced
this pull request
Jul 8, 2021
* decouple the DBM metrics collection interval from the check run interval * set default DBM metrics collection interval to 10s * change `statement_samples.collections_per_second` to `statement_samples.collection_interval` so it matches the new `statement_metrics.collection_interval` key Depends on #9656 Motivation: being able to configure the DBM metrics collection interval separately from the check run interval enables us to use a 10 second interval (by default) for the query metrics. There are various difficulties when querying metrics that have a 15 second interval (i.e. ensuring a correct rollup window for varying time ranges) that don't exist with a 10 second interval.
djova
added a commit
that referenced
this pull request
Jul 8, 2021
* decouple the DBM metrics collection interval from the check run interval * set default DBM metrics collection interval to 10s * change `statement_samples.collections_per_second` to `statement_samples.collection_interval` so it matches the new `statement_metrics.collection_interval` key Depends on #9656 Motivation: being able to configure the DBM metrics collection interval separately from the check run interval enables us to use a 10 second interval (by default) for the query metrics. There are various difficulties when querying metrics that have a 15 second interval (i.e. ensuring a correct rollup window for varying time ranges) that don't exist with a 10 second interval.
djova
added a commit
that referenced
this pull request
Jul 8, 2021
* decouple the DBM metrics collection interval from the check run interval * set default DBM metrics collection interval to 10s * change `statement_samples.collections_per_second` to `statement_samples.collection_interval` so it matches the new `statement_metrics.collection_interval` key Depends on #9656 Motivation: Being able to configure the DBM metrics collection interval separately from the check run interval enables us to use a 10 second interval (by default) for the query metrics. There are various difficulties when querying metrics that have a 15 second interval (i.e. ensuring a correct rollup window for varying time ranges) that don't exist with a 10 second interval.
djova
added a commit
that referenced
this pull request
Jul 9, 2021
* decouple DBM query metrics interval from check run interval * decouple the DBM metrics collection interval from the check run interval * set default DBM metrics collection interval to 10s * change `statement_samples.collections_per_second` to `statement_samples.collection_interval` so it matches the new `statement_metrics.collection_interval` key Depends on #9656 Motivation: being able to configure the DBM metrics collection interval separately from the check run interval enables us to use a 10 second interval (by default) for the query metrics. There are various difficulties when querying metrics that have a 15 second interval (i.e. ensuring a correct rollup window for varying time ranges) that don't exist with a 10 second interval. * update config spec & model
djova
added a commit
that referenced
this pull request
Jul 9, 2021
* decouple DBM query metrics interval from check run interval * decouple the DBM metrics collection interval from the check run interval * set default DBM metrics collection interval to 10s * change `statement_samples.collections_per_second` to `statement_samples.collection_interval` so it matches the new `statement_metrics.collection_interval` key Depends on #9656 Motivation: Being able to configure the DBM metrics collection interval separately from the check run interval enables us to use a 10 second interval (by default) for the query metrics. There are various difficulties when querying metrics that have a 15 second interval (i.e. ensuring a correct rollup window for varying time ranges) that don't exist with a 10 second interval. * update spec and model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a new
DBMAsyncJobclass which will be used by thepostgresandmysqlchecks to schedule asynchronous tasks that need to run independently of the main check.Follow-up PRs:
Motivation
Standardize approach for doing work asynchronously using threads for DBM.
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached