Merge pull request #1 from iwasakims/hbase

adding descriptions about replication.
DataDog · May 22, 2017 · ccedd55 · ccedd55
2 parents 314741a + 3eed893
commit ccedd55
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 5 deletions.
diff --git a/hbase_regionserver/_gen.rb b/hbase_regionserver/_gen.rb
@@ -31,7 +31,7 @@
 def decorate_descrption(metric, dumped_attribute)
   if Hash === dumped_attribute && dumped_attribute.has_key?("description")
     metric["description"] = dumped_attribute["description"]
-  else
+  elsif not metric.has_key?("description")
     metric["description"] = ""
   end
 end

diff --git a/hbase_regionserver/_metrics.yml b/hbase_regionserver/_metrics.yml
@@ -41,14 +41,18 @@
   attribute: sink.appliedOps
   metric_type: gauge
   alias: hbase.regionserver.replication.sink.applied_ops
+  description: Number of WAL entries applied on replication sink.
 - bean: Hadoop:service=HBase,name=RegionServer,sub=Replication
   attribute: sink.ageOfLastAppliedOp
   metric_type: gauge
   alias: hbase.regionserver.replication.sink.age_of_last_applied_op
+  description: Replication time lag of last applied WAL entry between source and sink.
+  unit_name: millisecond
 - bean: Hadoop:service=HBase,name=RegionServer,sub=Replication
   attribute: sink.appliedBatches
   metric_type: gauge
   alias: hbase.regionserver.replication.sink.applied_batches
+  description: Number of WAL applying operations processd on replication sink.
 - bean: Hadoop:service=HBase,name=RegionServer,sub=Server
   attribute: regionCount
   metric_type: gauge

diff --git a/hbase_regionserver/conf.yaml.example b/hbase_regionserver/conf.yaml.example
@@ -1,6 +1,6 @@
 instances:
   - host: localhost
-    port: 10102 # This is the JMX port on which HBase RegionServer exposes its metrics (usually 10101)
+    port: 10102 # This is the JMX port on which HBase RegionServer exposes its metrics (usually 10102)
     tags:
       hbase: regionserver
       # env: stage
@@ -70,12 +70,15 @@ init_config:
         bean:
          - Hadoop:service=HBase,name=RegionServer,sub=Replication
         attribute:
+          # Number of WAL entries applied on replication sink.
           sink.appliedOps:
             metric_type: gauge
             alias: hbase.regionserver.replication.sink.applied_ops
+          # Replication time lag of last applied WAL entry between source and sink.
           sink.ageOfLastAppliedOp:
             metric_type: gauge
             alias: hbase.regionserver.replication.sink.age_of_last_applied_op
+          # Number of WAL applying operations processd on replication sink.
           sink.appliedBatches:
             metric_type: gauge
             alias: hbase.regionserver.replication.sink.applied_batches
@@ -625,3 +628,4 @@ init_config:
           GcTimeMillis:
             metric_type: gauge
             alias: hbase.jvm_metrics.gc_time_millis
+
diff --git a/hbase_regionserver/metadata.csv b/hbase_regionserver/metadata.csv
@@ -7,9 +7,9 @@ hbase.regionserver.ipc.total_call_time.mean,gauge,"",millisecond,"","total call
 hbase.regionserver.ipc.total_call_time.median,gauge,"",millisecond,"","total call time, including both queued and processing time.",0,hbase_regionserver,""
 hbase.regionserver.ipc.total_call_time.percentile.99,gauge,"",millisecond,"","total call time, including both queued and processing time.",0,hbase_regionserver,""
 hbase.regionserver.regions.num_regions,gauge,"","","",Number of regions in the metrics system,0,hbase_regionserver,""
-hbase.regionserver.replication.sink.applied_ops,gauge,"","","","",0,hbase_regionserver,""
-hbase.regionserver.replication.sink.age_of_last_applied_op,gauge,"","","","",0,hbase_regionserver,""
-hbase.regionserver.replication.sink.applied_batches,gauge,"","","","",0,hbase_regionserver,""
+hbase.regionserver.replication.sink.applied_ops,gauge,"","","",Number of WAL entries applied on replication sink.,0,hbase_regionserver,""
+hbase.regionserver.replication.sink.age_of_last_applied_op,gauge,"",millisecond,"",Replication time lag of last applied WAL entry between source and sink.,0,hbase_regionserver,""
+hbase.regionserver.replication.sink.applied_batches,gauge,"","","",Number of WAL applying operations processd on replication sink.,0,hbase_regionserver,""
 hbase.regionserver.server.region_count,gauge,"","","",Number of regions,0,hbase_regionserver,""
 hbase.regionserver.server.store_count,gauge,"","","",Number of Stores,0,hbase_regionserver,""
 hbase.regionserver.server.hlog_file_count,gauge,"","","",Number of WAL Files,0,hbase_regionserver,""