[redis-sentinel] adding integration with SDK scaffolding/testing facilities. #5
Conversation
|
Looking good on CircleCI - tests fail because they should. |
|
Is there anything I can do to get this merged and released? |
truthbk
force-pushed
the
jaime/redis-sentinel
branch
from
479da7b to
6749372
Compare
|
Hello. integrations-extras is a new community-driven repository for integrations written and maintained outside Datadog. While support is on a best-effort basis, we're happy to help with code reviews and testing. The integrations won't be bundled with the agent, but will be installable on an individual basis. With that in mind, would you be interested in being the initial maintainer for the |
|
Thanks @truthbk. Well we plan to use redis{-sentinel} integrations in foreseeable future in production, so I guess I can at least try and do my best. What do you think? |
|
Sorry for the delay @krasnoukhov (been relocating back to Europe and it's been a crazy last couple of weeks). I think that if you're happy to give it a shot, that would be awesome. Please reconfirm, and then we can work on putting the finishing touches on this one before merging! Thank you so much! 🙇 |
|
Hello @truthbk. I deployed this to production earlier today, and overall it seems to be working just fine, except of this change I had to make: https://github.com/simplepractice/integrations-extras/commit/2c57715851cb64ab24bee443c09cbb5cf1ccdeac What would be the process to move forward? |
|
Also, seems like Travis CI is failing but I'm not sure what's the reason. Will you look into it? |
|
@krasnoukhov indeed, it's a problem in our CI, looking at it... |
truthbk
force-pushed
the
jaime/redis-sentinel
branch
from
abfaa73 to
1fd3f5e
Compare
* Adds cloudzero integration * updates app id to match app uuid from OAuth client (#1) * CP-13295 update datadog integration tile (#2) * Adds images * Updates manifest with images and suggested tag * Update readme to include marketing and setup language * formatting * CP-13295 Updates based on DD feedback (#3) * CP-13295 Updates based on further feedback (#4) * Updates based on copy feedback (#5) * CP-13295 Updates based on DD eng feedback (#6) * CP-13295 Copy changes requested by Datadog (#7) * Change from h3 to h2 (#9) * CP-13295 Update release date (#10)
added metric help links to dashboard
* update overview and description * add integrtaion version * add classifier tags * add dashboard description
* [ENT-2819] Robust Intelligence AI firewall integration initial commit (#1) * initial commit for check * check with correct metrics * add dashboard * update dashboard and readme * update dashboard title * fix readme links and add logos * fix support email link * update homepage and support email * [END-2821] Update README (#2) * update section on metrics collected * update firewall link and dashboard * [PINT-2462] readme fixes (#3) * readme fixes * update risk name * fix metrics section content * add image assets * [PINT-2485] PR build issues (#4) * lint fixes * add sales email * [PINT-2485] Address PR comments (#5) * update overview and description * add integrtaion version * add classifier tags * add dashboard description * add dashboard to manifest (#6) * [PINT-2541] readme review (#7) * add details to configure section * Add suggestion Co-authored-by: Arley Lewis <[email protected]> --------- Co-authored-by: Arley Lewis <[email protected]> * [PINT-2618] PR feedback and dashboard update (#8) * update readme and remove unnecessary file * upgrade dashboard * [PINT-2651] add dashboard banner image (#9) * add dashboard banner * update banner url * address PR comments (#10) * update description (#11) * [PINT-2719] readme and dashboard image (#12) * update dashboard image and description * update firewall image * update image ratio (#13) * [PINT-2891] add scope variable to dashboard (#14) * add scope variable * fix description * remove folder (#15) * fix import (#16) * run ddev validate ci * fix codecov * remove assets that are not required * add metrics check * add codeowners * fix format * remove non ascii character * fix test * add test --------- Co-authored-by: Arley Lewis <[email protected]>
What