Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sqreen README #975

Merged
merged 3 commits into from
Aug 31, 2021
Merged

Fix Sqreen README #975

merged 3 commits into from
Aug 31, 2021

Conversation

yzhan289
Copy link
Contributor

Links aren't working when using ()

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

Additional Notes

Anything else we should know when reviewing?

Links aren't working when using `()`
@yzhan289 yzhan289 requested review from a team as code owners August 31, 2021 17:37
Copy link
Contributor

@alai97 alai97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the links, @yzhan289! If you don't mind, I included some minor copy suggestions as well.

sqreen/README.md Outdated Show resolved Hide resolved
sqreen/README.md Outdated Show resolved Hide resolved
sqreen/README.md Outdated Show resolved Hide resolved
sqreen/README.md Outdated Show resolved Hide resolved
@alai97 alai97 merged commit 4f951ff into master Aug 31, 2021
@alai97 alai97 deleted the yzhan289-patch-1 branch August 31, 2021 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants