add support for rmi registry connection over ssl #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbll
changed the title
hush-hush
approved these changes
Oct 4, 2018
|
very nice 👌 I might be stating the obvious, but let's document these new options in the |
This was referenced Oct 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
We were previously only supporting SSL for connections to RMI servers and not for connections to the RMI registry.
Users will most likely want to authenticate their JMX clients using 2-way ssl as this is recommended here https://docs.oracle.com/javase/8/docs/technotes/guides/management/agent.html.
This means we also need to use a keystore for the client, which is why I added two new config options.
Motivation
Client request