Do not scope MBeans queries on list_not_matching_attributes action
#102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivielpeau
referenced
this pull request
Jun 3, 2016
Do not scope MBeans queries on `list_everything` or `list_not_matching_attributes`. Fix regression introduced with #63.
|
Thanks for fixing this. The code looks good to me. I guess this is not easily testable? I'm currently thinking about doing some more testing for this component. Once again, thank you for taking the time to fix this. |
|
Thanks @nwillems @olivielpeau.
One way I could think of, would be to mock the Still, I think this should go out Yann |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kudos to @nwillems for finding this bug! (4d9b0fa#commitcomment-17642270)
cc @yannmh