Fix JMX metric name for G1GC old generation statistics. #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dpratt! Thanks for your PR 😃 Can we be sure |
|
@albertvaka I can't say for sure that it isn't, but across OpenJDK Java 8, 9, 10, 11 and 12 it's referenced as "G1 Old Generation". I heavily suspect that if it were to show up it would likely be mutually exclusive with the name referenced above - it couldn't hurt to have both of them in the default JMX config file for safety purposes. |
|
@dpratt can you change the PR to keep both the |
|
Done - I've pushed that change. |
|
Thanks a lot @dpratt, merging! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #230