Avoid thread leak and data race in cleanUpAsync #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A thread started in cleanUpAsync may overlap with Instance#init called from fixBrokenInstances, closing a new freshly created connection object instead of the old one. This is fixed by capturing specific connection object in the thread, not the whole instance. If a connection issue persists over multiple collection intervals, there will be multiple calls to cleanUpAsync while an Instance references the same connection object. closeConnector may block to wait for a network protocol timeout; and, because the implementation is synchronized, multiple concurrent calls will wait for it sequentially, causing build-up of threads all waiting to close a connection. Reset the Instance connection to null, to make sure only one thread is trying to close a connection.
carlosroman
approved these changes
Apr 19, 2023
|
This changes may have caused #519 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A thread started in cleanUpAsync may overlap with Instance#init called from fixBrokenInstances, closing a new freshly created connection object instead of the old one. This is fixed by capturing specific connection object in the thread, not the whole instance.
If a connection issue persists over multiple collection intervals, there will be multiple calls to cleanUpAsync while an Instance references the same connection object. closeConnector may block to wait for a network protocol timeout; and, because the implementation is synchronized, multiple concurrent calls will wait for it sequentially, causing build-up of threads all waiting to close a connection. Reset the Instance connection to null, to make sure only one thread is trying to close a connection.