Bean name matching logic: OR→AND #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support 'float' and 'java.lang.Float' attribute types as simple JMX attrbutes.
Introduce a `TestCommon` parent class to refactor JUnit tests. Features: * One-liner `registerMBean` method * One-liner `initApplication` nethod * Automatically unregister MBeans after execution of every test * More eye candies
Add two new methods to `TestCommon` test class to refactor JUnit tests. * `assertMetric`: assert that a specific metric was collected * `assertCoverage`: assert that all -excluding JVM related- metrics were tested. Refactor `TestApp` tests.
Assert `java.lang.Float` attribute type support.
`matchBeanName` was incorrectly reporting `true` as soon as one bean parameter in a configuration was matching and regardless of the others. To sum up, fix bean parameters matching logic: `OR`→`AND`
| assertMetric("test.boolean", 1.0, commonTags, 5); | ||
| assertMetric("test.defaulted", 32.0, commonTags, 5); | ||
| assertMetric("subattr.this.is.0", 0.0, commonTags, 5); | ||
| assertMetric("subattr.this.is.0", 0.0, commonTags, 5); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matchBeanNamewas incorrectly reportingtrueas soon as onebean parameter in a configuration was matching and regardless of the
others.
To sum up, fix bean parameters matching logic:
OR→AND