[service-checks] adds tags from configuration file to service checks #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had to make small changes to some of the tests. With this change they were expecting the wrong number of tags. |
| @@ -83,7 +83,7 @@ public void testServiceCheckWarning() throws Exception { | |||
| assertEquals(Reporter.formatServiceCheckPrefix("too_many_metrics"), scName); | |||
| // We should have an OK service check status when too many metrics are getting sent | |||
| assertEquals(Status.STATUS_OK, scStatus); | |||
| assertEquals(scTags.length, 1); | |||
| assertEquals(scTags.length, 3); | |||
| assertTrue(Arrays.asList(scTags).contains("instance:jmx_test_instance")); | |||
There was a problem hiding this comment.
Can we tests the value of the 2 extra tags too ?
There was a problem hiding this comment.
Yes, I can do that. In fact it was a good idea. The way I was adding tags made these tags:
env: stage
newTag: testbe output as just stage and test I've added another commit that will change that to env:stage newTag:test which is what I assume we want.
|
It looks good to me. |
|
Nice, let's merge it. |
yannmh
added a commit
to DataDog/dd-agent
that referenced
this pull request
May 13, 2016
**Changes** * [BUGFIX] Report properly beans with ':' in the name. See [#90][], * [#91][], [#95][] (Thanks [@Bluestix][]) * [BUGFIX] Sanitize metric names and tags, i.e. remove illegal * characters. See [#89][] * [BUGFIX] Support `javax.management.Attribute` attribute types. See * [#92][] (Thanks [@nwillems][]) * [FEATURE] Add user tags to service checks. See [#96][] * [FEATURE] Allow group name substitutions in attribute/alias * parameters. See [#94][], [#97][] (Thanks [@alz][]) <!--- The following link definition list is generated by PimpMyChangelog ---> [#89]: DataDog/jmxfetch#89 [#90]: DataDog/jmxfetch#90 [#91]: DataDog/jmxfetch#91 [#92]: DataDog/jmxfetch#92 [#94]: DataDog/jmxfetch#94 [#95]: DataDog/jmxfetch#95 [#96]: DataDog/jmxfetch#96 [#97]: DataDog/jmxfetch#97 [@alz]: https://github.com/alz [@Bluestix]: https://github.com/bluestix [@nwillems]: https://github.com/nwillems
yannmh
added a commit
to DataDog/dd-agent
that referenced
this pull request
May 13, 2016
**Changes** * [BUGFIX] Report properly beans with ':' in the name. See [#90][], * [#91][], [#95][] (Thanks [@Bluestix][]) * [BUGFIX] Sanitize metric names and tags, i.e. remove illegal * characters. See [#89][] * [BUGFIX] Support `javax.management.Attribute` attribute types. See * [#92][] (Thanks [@nwillems][]) * [FEATURE] Add user tags to service checks. See [#96][] * [FEATURE] Allow group name substitutions in attribute/alias * parameters. See [#94][], [#97][] (Thanks [@alz][]) <!--- The following link definition list is generated by PimpMyChangelog ---> [#89]: DataDog/jmxfetch#89 [#90]: DataDog/jmxfetch#90 [#91]: DataDog/jmxfetch#91 [#92]: DataDog/jmxfetch#92 [#94]: DataDog/jmxfetch#94 [#95]: DataDog/jmxfetch#95 [#96]: DataDog/jmxfetch#96 [#97]: DataDog/jmxfetch#97 [@alz]: https://github.com/alz [@Bluestix]: https://github.com/bluestix [@nwillems]: https://github.com/nwillems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, only the scope and instance tags are available on service checks.
This PR will make it so that, in addition to those tags, all the tags defined in the configuration file will be available to service checks, making it much easier to scope an integration monitor to a set of hosts.