Add windows support #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More readability.
/!\ Dirty fix /!\ We don't have an `extra_package_file` directive for Windows builds (there's one but it doesn't do anything) and as a matter of fact, it wouldn't make much sense since the directories in whcih we'd like to put these files are often User/System dependant or user configurable. We added a routine to add such files under a directory defined in the `source.wxs` file and referenced by it's id. To achieve that, the only thing that needs to be done is to copy the extra files under `<main_software_source_dir>/EXTRA_PACKAGE_FILES/DIRECTORY_ID`.
Otherwise it sometimes results in errors like that on Windows : tar (child): Cannot connect to C: resolve failed due to path containing ':', for instance "C:\Users".
This was referenced Apr 13, 2016
Latest tar shipped with omnibus cookbook does not accept it.
|
Closed by mistake. Replaced by #20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a few Datadog-specific patches for Omnibus to build the Windows agent.
@elafarge is the main author of this PR, I updated it for omnibus 5.0, fixed a couple things and rebased.
Previous state
Omnibus 5.0 not tested with Windows.
What does this PR do ?
Add the ability to ship extra files in the final MSI.
Fix an issue with spaces in path and tar on Windows.
Add a
pipDSL. (because it's easier and more beautiful to use)Does it affect other platforms ?
pipDSL (see omnibus-software)Related PR
DataDog/dd-agent#2417
DataDog/dd-agent-omnibus#74
DataDog/omnibus-software#48
https://github.com/DataDog/osx-dd-agent-build-box/pull/1