-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make a generic define for creating integrations #141
Conversation
there is a couple use causes here mostly I need this so I can define my integratins in hiera. eg; ---
datadog_agent::integrations::
apache:
instances:
- something: goeshere
- anthorthing: goesheretoo which sould turn into the client being like this #/etc/dd-agent/integrations/apache.yaml
---
init_config:
instances:
- something: goeshere
- anotherthing: goesheretoo |
@cwood Thanks for your efforts here. Our team will review shortly. In the mean time, can you help rebase/resolve the merge conflicts? That will help with testing/review. |
Sounds good @irabinovitch |
7be0af5
to
71cd24c
Compare
72316cf
to
5d50a3d
Compare
Iv done a rebase onto upstream master. Would love to get this merged in. |
Iv fixed the tests for this. So should be good. |
Any update on if this can get merged in? This could solve alot of your other intergration problems. Since this is a simple ruby -> yaml conversion. We have been using this for other integrations not even provided via a class in this module. |
@cwood real sorry to ask you to rebase again, and maybe address the conflicts please. Once that's done I'll move quickly - promised 😊 |
There is one already but only allows one since its a class we can not do a bunch of integrations and replace the class with this. Also this will allow you to write ruby, or hiera and put it in the config you need.
1a3ee0e
to
f02fb0b
Compare
Looks like the build is failing for a gem depdencie rahter than from code. |
@cwood - indeed this is unrelated to your changes. Hoping to fix travis soon (I've got it ~66% of the way solved), still having some issues with ruby 2.2.3 and some older puppet module versions. I'll ping you to rebase soon. Apologies. |
@truthbk is there anything I can do to speed up this process? This has been on going for months now and I still havnt gotten any traction. This would save people a lot of time and just allow generic intergrations via hiera instead of special classes for every type of integration, + every custom check people want to write. |
Merged #233 - closing this one. |
Wish I had this much speed heh. |
This is a additional feature to add support of a generic define and then use yaml to convert the ruby data to a yaml format. This should make it so each integration is dynamic and allows for a full feature rich integration. A addition would be to make a $integartions argument in the main class to use hiera to declare integrations