Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default port values to strings, as expected by datadog.conf.erb #151

Closed
wants to merge 1 commit into from

Conversation

Dvanderspuij
Copy link

If the port variables are not defined, puppet will fail on parsing the template.

Error when parsing template
Error: Evaluation Error: Error while evaluating a Function Call, Failed to parse template datadog_agent/datadog.conf.erb:
==> nodejs-es: Filepath: /tmp/vagrant-puppet/modules-71d71bfb0a46455123a5017c4c54e211/datadog_agent/templates/datadog.conf.erb
==> nodejs-es: Line: 137
==> nodejs-es: Detail: undefined method `empty?' for 8125:Fixnum

@joelnn
Copy link

joelnn commented Dec 8, 2015

+1, I ran into this with 1.5.0

@talwai talwai modified the milestones: 1.6.0, triage Jan 11, 2016
@wazoo
Copy link

wazoo commented Jan 13, 2016

I also ran into this in 1.5.0, I was able to get around it by just overriding the defaults in my wrapper class to be strings (still using default values) if anyone else is looking for a fix until this is merged.

@truthbk
Copy link
Member

truthbk commented Jan 20, 2016

Thanks for this @Dvanderspuij , we identified the root cause and addressed it with 6244659 in PR #161

This should be sorted in our next release! :)

@truthbk truthbk closed this Jan 20, 2016
@Dvanderspuij
Copy link
Author

👍 Nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants