Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ability to manage disk.yaml #179

Closed
wants to merge 1 commit into from
Closed

Adding ability to manage disk.yaml #179

wants to merge 1 commit into from

Conversation

babyhuey
Copy link

Added disk.pp and disk.yaml.erb.

This allows the use of puppet to manage the disk.yaml config file through Puppet.

@velebak
Copy link

velebak commented Apr 26, 2016

+1

@truthbk
Copy link
Member

truthbk commented May 6, 2016

@babyhuey thanks for your PR! I'll review and test this soon. 😄

@truthbk truthbk added this to the triage milestone May 6, 2016
@truthbk
Copy link
Member

truthbk commented Jul 28, 2016

@babyhuey the template .erb is basically spitting a pre-configured file that isn't really configurable at all... That'd limit the usability of this integration with puppet pretty severely for other users. Do you think you can find the time to work on that? Let me know if it's not the case! Thanks a lot!

@truthbk
Copy link
Member

truthbk commented Mar 17, 2017

An alternative PR (#263) was merged instead. Thank you regardless @babyhuey!

@truthbk truthbk closed this Mar 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
triage
Development

Successfully merging this pull request may close these issues.
3 participants
@babyhuey @velebak @truthbk