Puppet runs are now idempotent on rhel 7 distros

[Sher-Chowdhury]

When I do puppet runs on centos7, I kept getting the following happening:

# puppet agent -t
Notice: Local environment: 'production' doesn't match server specified node environment 'development', switching agent to 'development'.
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Loading facts
Info: Caching catalog for xxxxxxxxxxxxxxxx
Info: Applying configuration version '1461254235'
Notice: /Stage[main]/Datadog_agent::Redhat/Service[datadog-agent]/enable: enable changed 'false' to 'true'
Notice: Applied catalog in 3.47 seconds

I.e. it isn't idempotent. Although it doesn't give any red error messages.

This change fixes this.

[truthbk]

@Sher-Chowdhury thanks a lot for this, I'll give it a test-drive and very likely merge into the next release.

[truthbk]

I'm not convinced about this, because of systemd (also a possible provider) - preferred over sysvinit init at this point. I think the right provider there would be redhat for RH-based distros (but I'm not sure if there could be compatibility issues with older puppets). I'm going to hold on merging this one for now.

(some context: https://tickets.puppetlabs.com/browse/PUP-2744)

[truthbk]

Indeed, setting to redhat is preferable and has been reported to fix the issue by another member of the community. Let's give that a shot instead @Sher-Chowdhury! Thanks anyways for raising this issue.