Added logs configuration #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajacquemot
force-pushed
the
ajacquemot/logs
branch
3 times, most recently
from
0e6c474 to
5c0a1b7
Compare
ajacquemot
force-pushed
the
ajacquemot/logs
branch
from
5c0a1b7 to
41abac9
Compare
truthbk
approved these changes
Jun 15, 2018
| @@ -528,6 +538,10 @@ | |||
| 'scrub_args' => $scrub_args, | |||
| 'custom_sensitive_words' => $custom_sensitive_words, | |||
| }, | |||
| 'logs_enabled' => $logs_enabled, | |||
| 'logs_config' => { | |||
There was a problem hiding this comment.
Just a note, this isn't documented in the config_template.yaml in the datadog-agent repo. Is that intentional or oversight?
There was a problem hiding this comment.
That's a good point, opening a PR right now, thanks
tmichelet
approved these changes
Jun 15, 2018
Closed
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Added the possibility to enable logs collection and to add logs integration configuration.
Motivation
Be able to configure the agent to collect logs with Puppet
Additional Notes
This should solve #382